Don't update Canary shortcuts from Dev/Beta/Stable installer.

chrome/installer/setup/install_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <objbase.h>
 #include <stddef.h>
 
 #include <string>
 
 #include "base/base_paths.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/scoped_path_override.h"
 #include "base/test/test_shortcut_win.h"
 #include "base/version.h"
 #include "base/win/shortcut.h"
 #include "chrome/installer/setup/install.h"
 #include "chrome/installer/setup/install_worker.h"
 #include "chrome/installer/setup/setup_constants.h"
 #include "chrome/installer/util/browser_distribution.h"
 #include "chrome/installer/util/install_util.h"
@@ skipping 425 matching lines @@
   installer::CreateOrUpdateShortcuts(
       chrome_exe_, *product_, *prefs_, installer::CURRENT_USER,
       installer::INSTALL_SHORTCUT_CREATE_EACH_IF_NO_SYSTEM_LEVEL);
   ASSERT_FALSE(base::PathExists(user_desktop_shortcut_));
   base::win::ValidateShortcut(user_quick_launch_shortcut_,
                               expected_properties_);
   base::win::ValidateShortcut(user_start_menu_shortcut_,
                               expected_start_menu_properties_);
 }
 
+TEST_F(InstallShortcutTest, UpdatePerUserShortcuts) {
+  base::FilePath shortcut_path_template;
+  ASSERT_TRUE(ShellUtil::GetShortcutPath(ShellUtil::SHORTCUT_LOCATION_DESKTOP,
+                                         dist_, ShellUtil::CURRENT_USER,
+                                         &shortcut_path_template));
+  shortcut_path_template =
+      shortcut_path_template.Append(FILE_PATH_LITERAL("shortcut.lnk"));

[gab, 2016/03/16 21:57:31]

You can use the fixture's |user_desktop_shortcut_| below instead and get rid of
|shortcut_path_template|.

[fdoray, 2016/03/17 00:50:34]

Done.

+
+  static const struct TestData {

[gab, 2016/03/16 21:57:30]

s/TestData/TestCase/

[fdoray, 2016/03/17 00:50:34]

Done.

+    const base::FilePath::CharType* relative_target_path;
+    bool should_update;
+  } kTargetPathsToUpdate[] = {
+      {FILE_PATH_LITERAL("AppData\\Local\\Google\\Chrome "
+                         "SxS\\Temp\\scoped_dir\\new_chrome.exe"),
+       false},
+      {FILE_PATH_LITERAL(
+           "AppData\\Local\\Google\\Chrome SxS\\Temp\\scoped_dir\\chrome.exe"),
+       false},
+      {FILE_PATH_LITERAL(
+           "AppData\\Local\\Google\\Chrome SxS\\Application\\chrome.exe"),
+       false},
+      {FILE_PATH_LITERAL("AppData\\Local\\Google\\Chrome "
+                         "SxS\\Application\\something_else.exe"),
+       false},
+      {FILE_PATH_LITERAL(
+           "AppData\\Local\\Google\\Chrome\\Temp\\scoped_dir\\new_chrome.exe"),
+       true},
+      {FILE_PATH_LITERAL(
+           "AppData\\Local\\Google\\Chrome\\Temp\\scoped_dir\\chrome.exe"),
+       true},
+      {FILE_PATH_LITERAL(
+           "AppData\\Local\\Google\\Chrome\\Application\\chrome.exe"),
+       true},
+      {FILE_PATH_LITERAL(
+           "AppData\\Local\\Google\\Chrome\\Application\\something_else.exe"),
+       false},
+      {FILE_PATH_LITERAL("something_else.exe"), false},
+  };
+
+  // Create shortcuts.
+  for (size_t i = 0; i < arraysize(kTargetPathsToUpdate); ++i) {
+    const base::FilePath target_path =
+        temp_dir_.path().Append(kTargetPathsToUpdate[i].relative_target_path);
+    ASSERT_TRUE(base::CreateDirectory(target_path.DirName()));
+    base::File file(target_path, base::File::FLAG_CREATE);
+    ASSERT_TRUE(file.IsValid());
+
+    base::win::ShortcutProperties properties;
+    properties.set_target(target_path);
+    ASSERT_TRUE(base::win::CreateOrUpdateShortcutLink(
+        shortcut_path_template.InsertBeforeExtension(base::SizeTToString16(i)),
+        properties, base::win::SHORTCUT_CREATE_ALWAYS));
+  }
+
+  // Update shortcuts.
+  const base::FilePath new_target_path =
+      temp_dir_.path().Append(FILE_PATH_LITERAL(
+          "AppData\\Local\\Google\\Chrome\\Application\\chrome.exe"));
+  installer::UpdatePerUserShortcutsInLocation(
+      ShellUtil::SHORTCUT_LOCATION_DESKTOP, dist_,
+      new_target_path.DirName().DirName(), new_target_path.BaseName(),
+      new_target_path);
+
+  // Check if shortcuts were updated correctly.

[gab, 2016/03/16 21:57:31]

s/Check if/Verify that/

[fdoray, 2016/03/17 00:50:34]

Done.

+  for (size_t i = 0; i < arraysize(kTargetPathsToUpdate); ++i) {
+    base::FilePath target_path;
+    ASSERT_TRUE(base::win::ResolveShortcut(
+        shortcut_path_template.InsertBeforeExtension(base::SizeTToString16(i)),
+        &target_path, nullptr));
+
+    if (kTargetPathsToUpdate[i].should_update) {
+      EXPECT_EQ(new_target_path, target_path);
+    } else {
+      EXPECT_EQ(
+          temp_dir_.path().Append(kTargetPathsToUpdate[i].relative_target_path),
+          target_path);
+    }
+  }
+}
+
+TEST_F(InstallShortcutTest, UpdatePerUserShortcutsCanary) {
+  base::FilePath shortcut_path_template;
+  ASSERT_TRUE(ShellUtil::GetShortcutPath(ShellUtil::SHORTCUT_LOCATION_DESKTOP,
+                                         dist_, ShellUtil::CURRENT_USER,
+                                         &shortcut_path_template));
+  shortcut_path_template =
+      shortcut_path_template.Append(FILE_PATH_LITERAL("shortcut.lnk"));
+
+  static const struct TestData {
+    const base::FilePath::CharType* relative_target_path;
+    bool should_update;
+  } kTargetPathsToUpdate[] = {
+      {FILE_PATH_LITERAL("AppData\\Local\\Google\\Chrome "
+                         "SxS\\Temp\\scoped_dir\\new_chrome.exe"),
+       true},
+      {FILE_PATH_LITERAL(
+           "AppData\\Local\\Google\\Chrome SxS\\Temp\\scoped_dir\\chrome.exe"),
+       true},
+      {FILE_PATH_LITERAL(
+           "AppData\\Local\\Google\\Chrome SxS\\Application\\chrome.exe"),
+       true},
+      {FILE_PATH_LITERAL("AppData\\Local\\Google\\Chrome "
+                         "SxS\\Application\\something_else.exe"),
+       false},
+      {FILE_PATH_LITERAL(
+           "AppData\\Local\\Google\\Chrome\\Temp\\scoped_dir\\new_chrome.exe"),
+       false},
+      {FILE_PATH_LITERAL(
+           "AppData\\Local\\Google\\Chrome\\Temp\\scoped_dir\\chrome.exe"),
+       false},
+      {FILE_PATH_LITERAL(
+           "AppData\\Local\\Google\\Chrome\\Application\\chrome.exe"),
+       false},
+      {FILE_PATH_LITERAL(
+           "AppData\\Local\\Google\\Chrome\\Application\\something_else.exe"),
+       false},
+      {FILE_PATH_LITERAL("something_else.exe"), false},
+  };
+
+  // Create shortcuts.
+  for (size_t i = 0; i < arraysize(kTargetPathsToUpdate); ++i) {
+    const base::FilePath target_path =
+        temp_dir_.path().Append(kTargetPathsToUpdate[i].relative_target_path);
+    ASSERT_TRUE(base::CreateDirectory(target_path.DirName()));
+    base::File file(target_path, base::File::FLAG_CREATE);
+    ASSERT_TRUE(file.IsValid());
+
+    base::win::ShortcutProperties properties;
+    properties.set_target(target_path);
+    ASSERT_TRUE(base::win::CreateOrUpdateShortcutLink(
+        shortcut_path_template.InsertBeforeExtension(base::SizeTToString16(i)),
+        properties, base::win::SHORTCUT_CREATE_ALWAYS));
+  }
+
+  // Update shortcuts.
+  const base::FilePath new_target_path =
+      temp_dir_.path().Append(FILE_PATH_LITERAL(
+          "AppData\\Local\\Google\\Chrome SxS\\Application\\chrome.exe"));
+  installer::UpdatePerUserShortcutsInLocation(
+      ShellUtil::SHORTCUT_LOCATION_DESKTOP, dist_,
+      new_target_path.DirName().DirName(), new_target_path.BaseName(),
+      new_target_path);
+
+  // Check if shortcuts were updated correctly.
+  for (size_t i = 0; i < arraysize(kTargetPathsToUpdate); ++i) {
+    base::FilePath target_path;
+    ASSERT_TRUE(base::win::ResolveShortcut(
+        shortcut_path_template.InsertBeforeExtension(base::SizeTToString16(i)),
+        &target_path, nullptr));
+
+    if (kTargetPathsToUpdate[i].should_update) {
+      EXPECT_EQ(new_target_path, target_path);
+    } else {
+      EXPECT_EQ(
+          temp_dir_.path().Append(kTargetPathsToUpdate[i].relative_target_path),
+          target_path);
+    }
+  }
+}
+
 TEST(EscapeXmlAttributeValueTest, EscapeCrazyValue) {
   base::string16 val(L"This has 'crazy' \"chars\" && < and > signs.");
   static const wchar_t kExpectedEscapedVal[] =
       L"This has &apos;crazy&apos; \"chars\" &amp;&amp; &lt; and > signs.";
   installer::EscapeXmlAttributeValueInSingleQuotes(&val);
   ASSERT_STREQ(kExpectedEscapedVal, val.c_str());
 }
 
 TEST(EscapeXmlAttributeValueTest, DontEscapeNormalValue) {
   base::string16 val(L"Google Chrome");
   static const wchar_t kExpectedEscapedVal[] = L"Google Chrome";
   installer::EscapeXmlAttributeValueInSingleQuotes(&val);
   ASSERT_STREQ(kExpectedEscapedVal, val.c_str());
 }