Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1803363003: [MD settings] change side nav and section labels (Closed)

Created:
4 years, 9 months ago by dschuyler
Modified:
4 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] change side nav and section labels This CL updates the section names (shown on the side nav and above each section). They use sentence case. The & symbol is replaced with 'and'. The Reset and Languages names have been shortened. BUG=593989 Committed: https://crrev.com/73a95df58dd368559e693279c7875b9808bd04d7 Cr-Commit-Position: refs/heads/master@{#381757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M chrome/app/settings_strings.grdp View 7 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
dschuyler
4 years, 9 months ago (2016-03-16 20:48:03 UTC) #2
Dan Beam
lgtm
4 years, 9 months ago (2016-03-17 02:05:43 UTC) #3
Dan Beam
for the CL description: "now use sentence case" (easier way to describe) https://en.wikipedia.org/wiki/Letter_case#Case_styles
4 years, 9 months ago (2016-03-17 02:06:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1803363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1803363003/1
4 years, 9 months ago (2016-03-17 18:27:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 18:34:35 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 18:36:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73a95df58dd368559e693279c7875b9808bd04d7
Cr-Commit-Position: refs/heads/master@{#381757}

Powered by Google App Engine
This is Rietveld 408576698