pkg/compiler/lib/src/js_backend/constant_emitter.dart - Issue 1803303002: Move all flags to CompilerOptions (first step to stop passing the compiler to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/constant_emitter.dart

Issue 1803303002: Move all flags to CompilerOptions (first step to stop passing the compiler to (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/compiler_new.dart ('K') | « pkg/compiler/lib/src/js_backend/codegen/task.dart ('k') | pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart » ('j') | pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_backend/constant_emitter.dart

diff --git a/pkg/compiler/lib/src/js_backend/constant_emitter.dart b/pkg/compiler/lib/src/js_backend/constant_emitter.dart

index 0550d8d1002f1e624c5b93a764b02d629d0f3771..9bb14173935072bc250e33954a1f2f295e9aa996 100644

--- a/pkg/compiler/lib/src/js_backend/constant_emitter.dart

+++ b/pkg/compiler/lib/src/js_backend/constant_emitter.dart

@@ -105,7 +105,7 @@ class ConstantEmitter

// digits are lost anyway.

String representation = primitiveValue.toString();

String alternative = null;

- int cutoff = compiler.enableMinification ? 10000 : 1e10.toInt();

+ int cutoff = compiler.options.enableMinification ? 10000 : 1e10.toInt();

if (primitiveValue.abs() >= cutoff) {

alternative = _shortenExponentialRepresentation(

primitiveValue.toStringAsExponential());

@@ -133,7 +133,7 @@ class ConstantEmitter

@override

jsAst.Expression visitBool(BoolConstantValue constant, [_]) {

- if (compiler.enableMinification) {

+ if (compiler.options.enableMinification) {

if (constant.isTrue) {

// Use !0 for true.

return js("!0");