pkg/compiler/lib/src/js/js.dart - Issue 1803303002: Move all flags to CompilerOptions (first step to stop passing the compiler to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js/js.dart

Issue 1803303002: Move all flags to CompilerOptions (first step to stop passing the compiler to (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/compiler_new.dart ('K') | « pkg/compiler/lib/src/inferrer/type_graph_nodes.dart ('k') | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js/js.dart

diff --git a/pkg/compiler/lib/src/js/js.dart b/pkg/compiler/lib/src/js/js.dart

index df510a854fcbb38363ccd9028427d0b70f267b38..837b9feadbcdf1729acf63ba183ff45badeb4504 100644

--- a/pkg/compiler/lib/src/js/js.dart

+++ b/pkg/compiler/lib/src/js/js.dart

@@ -27,7 +27,7 @@ String prettyPrint(

Renamer renamerForNames: JavaScriptPrintingOptions.identityRenamer}) {

// TODO(johnniwinther): Do we need all the options here?

JavaScriptPrintingOptions options = new JavaScriptPrintingOptions(

- shouldCompressOutput: compiler.enableMinification,

+ shouldCompressOutput: compiler.options.enableMinification,

minifyLocalVariables: allowVariableMinification,

preferSemicolonToNewlineInMinifiedOutput: USE_LAZY_EMITTER,

renamerForNames: renamerForNames);

@@ -47,7 +47,7 @@ CodeBuffer createCodeBuffer(

JavaScriptSourceInformationStrategy sourceInformationFactory =