pkg/compiler/lib/src/compile_time_constants.dart - Issue 1803303002: Move all flags to CompilerOptions (first step to stop passing the compiler to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/compile_time_constants.dart

Issue 1803303002: Move all flags to CompilerOptions (first step to stop passing the compiler to (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/compiler_new.dart ('K') | « pkg/compiler/lib/src/common/tasks.dart ('k') | pkg/compiler/lib/src/compiler.dart » ('j') | pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/compile_time_constants.dart

diff --git a/pkg/compiler/lib/src/compile_time_constants.dart b/pkg/compiler/lib/src/compile_time_constants.dart

index d633e6b1394eab126a3a3b88fffc02f70b9ce6bc..1eabdf3ef2c6fc7fe9a88adaa8749023c90812ee 100644

--- a/pkg/compiler/lib/src/compile_time_constants.dart

+++ b/pkg/compiler/lib/src/compile_time_constants.dart

@@ -243,7 +243,7 @@ abstract class ConstantCompilerBase implements ConstantCompiler {

} else {

expression = compileNodeWithDefinitions(initializer, definitions,

isConst: isConst);

- if (compiler.enableTypeAssertions &&

+ if (compiler.options.enableTypeAssertions &&

checkType &&

expression != null &&

element.isField) {

@@ -1079,7 +1079,7 @@ class ConstructorEvaluator extends CompileTimeConstantEvaluator {

}

void potentiallyCheckType(TypedElement element, AstConstant constant) {

- if (compiler.enableTypeAssertions) {

+ if (compiler.options.enableTypeAssertions) {

DartType elementType = element.type.substByContext(constructedType);

DartType constantType = constant.value.getType(coreTypes);

if (!constantSystem.isSubtype(