Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 180323002: [webcrypto] Add parameter parsing for AES-GCM. (Closed)

Created:
6 years, 10 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

[webcrypto] Add parameter parsing for AES-GCM. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167919

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove addition to Dictionary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -21 lines) Patch
M LayoutTests/crypto/encrypt-decrypt.html View 6 chunks +123 lines, -6 lines 0 comments Download
M LayoutTests/crypto/encrypt-decrypt-expected.txt View 4 chunks +43 lines, -5 lines 0 comments Download
M LayoutTests/crypto/resources/common.js View 1 chunk +3 lines, -1 line 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 1 11 chunks +138 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
eroman
6 years, 10 months ago (2014-02-25 19:59:20 UTC) #1
sof
https://codereview.chromium.org/180323002/diff/1/Source/bindings/v8/Dictionary.cpp File Source/bindings/v8/Dictionary.cpp (right): https://codereview.chromium.org/180323002/diff/1/Source/bindings/v8/Dictionary.cpp#newcode442 Source/bindings/v8/Dictionary.cpp:442: hasValue = false; Hmm, this extra reference argument seems ...
6 years, 10 months ago (2014-02-25 22:01:44 UTC) #2
eroman
https://codereview.chromium.org/180323002/diff/1/Source/bindings/v8/Dictionary.cpp File Source/bindings/v8/Dictionary.cpp (right): https://codereview.chromium.org/180323002/diff/1/Source/bindings/v8/Dictionary.cpp#newcode442 Source/bindings/v8/Dictionary.cpp:442: hasValue = false; On 2014/02/25 22:01:45, sof wrote: > ...
6 years, 10 months ago (2014-02-25 22:23:28 UTC) #3
eroman
https://codereview.chromium.org/180323002/diff/1/Source/bindings/v8/Dictionary.cpp File Source/bindings/v8/Dictionary.cpp (right): https://codereview.chromium.org/180323002/diff/1/Source/bindings/v8/Dictionary.cpp#newcode442 Source/bindings/v8/Dictionary.cpp:442: hasValue = false; On 2014/02/25 22:23:29, eroman wrote: > ...
6 years, 10 months ago (2014-02-25 22:31:00 UTC) #4
abarth-chromium
lgtm
6 years, 10 months ago (2014-02-26 05:55:34 UTC) #5
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 10 months ago (2014-02-26 05:55:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/180323002/20001
6 years, 10 months ago (2014-02-26 05:56:16 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-26 12:17:49 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=14170
6 years, 10 months ago (2014-02-26 12:17:50 UTC) #9
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-02-26 16:23:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/180323002/20001
6 years, 9 months ago (2014-02-26 16:23:34 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-02-26 19:34:42 UTC) #12
Message was sent while issue was closed. 
Change committed as 167919

Powered by Google App Engine
This is Rietveld 408576698