third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp - Issue 1803153002: Add min/max values for AudioParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp

Issue 1803153002: Add min/max values for AudioParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp b/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp

index 8636b518f061a1cc7f443949e779d1e406b26e5c..3dc83b36be3147145fb06f1a7a1a3e493f88b061 100644

--- a/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp

@@ -333,7 +333,7 @@ bool OscillatorHandler::propagatesSilence() const

OscillatorNode::OscillatorNode(AbstractAudioContext& context, float sampleRate)

: AudioScheduledSourceNode(context)

// Use musical pitch standard A440 as a default.

- , m_frequency(AudioParam::create(context, ParamTypeOscillatorFrequency, 440))

+ , m_frequency(AudioParam::create(context, ParamTypeOscillatorFrequency, 440, 0, sampleRate / 2))

// Default to no detuning.

, m_detune(AudioParam::create(context, ParamTypeOscillatorDetune, 0))

{