third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp - Issue 1803153002: Add min/max values for AudioParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

Issue 1803153002: Add min/max values for AudioParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add warnings for automations Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AudioParam.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/DelayNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

index dd77f7ba62780d07d1bdf980f8390e06ed525b65..63b5dad09d7297cbcb822686ba7352b0be92a0b0 100644

--- a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

@@ -127,11 +127,11 @@ double DynamicsCompressorHandler::latencyTime() const

DynamicsCompressorNode::DynamicsCompressorNode(AbstractAudioContext& context, float sampleRate)

: AudioNode(context)

- , m_threshold(AudioParam::create(context, ParamTypeDynamicsCompressorThreshold, -24))

- , m_knee(AudioParam::create(context, ParamTypeDynamicsCompressorKnee, 30))

- , m_ratio(AudioParam::create(context, ParamTypeDynamicsCompressorRatio, 12))

- , m_attack(AudioParam::create(context, ParamTypeDynamicsCompressorAttack, 0.003))

- , m_release(AudioParam::create(context, ParamTypeDynamicsCompressorRelease, 0.250))

+ , m_threshold(AudioParam::create(context, ParamTypeDynamicsCompressorThreshold, -24, -100, 0))

+ , m_knee(AudioParam::create(context, ParamTypeDynamicsCompressorKnee, 30, 0, 40))

+ , m_ratio(AudioParam::create(context, ParamTypeDynamicsCompressorRatio, 12, 1, 20))

+ , m_attack(AudioParam::create(context, ParamTypeDynamicsCompressorAttack, 0.003, 0, 1))

+ , m_release(AudioParam::create(context, ParamTypeDynamicsCompressorRelease, 0.250, 0, 1))

{

setHandler(DynamicsCompressorHandler::create(

*this,