third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp - Issue 1803153002: Add min/max values for AudioParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

Issue 1803153002: Add min/max values for AudioParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt ('K') | « third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt ('k') | third_party/WebKit/Source/modules/webaudio/AudioParam.h » ('j') | third_party/WebKit/Source/modules/webaudio/AudioParam.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

index ed2437638e4ba271e2ff09c98190ed1da9b06a50..ba019b98955c60771edd9f26e3d96d165f6280ca 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

@@ -583,7 +583,8 @@ void AudioBufferSourceHandler::handleStoppableSourceNode()

// ----------------------------------------------------------------

AudioBufferSourceNode::AudioBufferSourceNode(AbstractAudioContext& context, float sampleRate)

: AudioScheduledSourceNode(context)

- , m_playbackRate(AudioParam::create(context, ParamTypeAudioBufferSourcePlaybackRate, 1.0))

+ // Arbitrarily choose a limit of +/- Nyquist frequency for playback

hongchan 2016/05/13 01:30:14 Not arbitrarily - it is based on the spec. Right?

Raymond Toy 2016/05/13 17:06:15 Forgot to update it after it was decided to be unl

Raymond Toy 2016/05/13 18:40:32 Done.

+ , m_playbackRate(AudioParam::create(context, ParamTypeAudioBufferSourcePlaybackRate, 1.0, -sampleRate / 2, sampleRate / 2))

, m_detune(AudioParam::create(context, ParamTypeAudioBufferSourceDetune, 0.0))

{

setHandler(AudioBufferSourceHandler::create(*this, sampleRate, m_playbackRate->handler(), m_detune->handler()));