Add min/max values for AudioParams

third_party/WebKit/Source/modules/webaudio/AudioParam.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 63 matching lines @@
 // dies.
 class AudioParamHandler final : public ThreadSafeRefCounted<AudioParamHandler>, public AudioSummingJunction {
 public:
     AudioParamType getParamType() const { return m_paramType; }
     // Return a nice name for the AudioParam.
     String getParamName() const;
 
     static const double DefaultSmoothingConstant;
     static const double SnapThreshold;
 
-    static PassRefPtr<AudioParamHandler> create(AbstractAudioContext& context, AudioParamType paramType, double defaultValue)
+    static PassRefPtr<AudioParamHandler> create(
+        AbstractAudioContext& context,
+        AudioParamType paramType,
+        double defaultValue,
+        float min,
+        float max)

[hongchan, 2016/05/13 01:30:15]

Even for internal variables - I suggest we should use minValue/maxValue.

[Raymond Toy, 2016/05/13 18:40:32]

Done.

     {
-        return adoptRef(new AudioParamHandler(context, paramType, defaultValue));
+        return adoptRef(new AudioParamHandler(context, paramType, defaultValue, min, max));

[hongchan, 2016/05/13 01:30:15]

Ditto.

[Raymond Toy, 2016/05/13 18:40:32]

Done.

     }
 
     // This should be used only in audio rendering thread.
     AudioDestinationHandler& destinationHandler() const;
 
     // AudioSummingJunction
     void didUpdate() override { }
 
     AudioParamTimeline& timeline() { return m_timeline; }
 
     // Intrinsic value.
     float value();
     void setValue(float);
 
     // Final value for k-rate parameters, otherwise use calculateSampleAccurateValues() for a-rate.
     // Must be called in the audio thread.
     float finalValue();
 
     float defaultValue() const { return static_cast<float>(m_defaultValue); }
+    float minValue() const { return m_minValue; }
+    float maxValue() const { return m_maxValue; }
 
     // Value smoothing:
 
     // When a new value is set with setValue(), in our internal use of the parameter we don't immediately jump to it.
     // Instead we smoothly approach this value to avoid glitching.
     float smoothedValue();
 
     // Smoothly exponentially approaches to (de-zippers) the desired value.
     // Returns true if smoothed value has already snapped exactly to value.
     bool smooth();
 
     void resetSmoothedValue() { m_smoothedValue = intrinsicValue(); }
 
     bool hasSampleAccurateValues() { return m_timeline.hasValues() || numberOfRenderingConnections(); }
 
     // Calculates numberOfValues parameter values starting at the context's current time.
     // Must be called in the context's render thread.
     void calculateSampleAccurateValues(float* values, unsigned numberOfValues);
 
     // Connect an audio-rate signal to control this parameter.
     void connect(AudioNodeOutput&);
     void disconnect(AudioNodeOutput&);
 
     float intrinsicValue() const { return noBarrierLoad(&m_intrinsicValue); }
 private:
-    AudioParamHandler(AbstractAudioContext&, AudioParamType, double defaultValue);
+    AudioParamHandler(AbstractAudioContext&, AudioParamType, double defaultValue, float min, float max);
+
+    void warnIfOutsideRange(float value, float minValue, float maxValue);
 
     // sampleAccurate corresponds to a-rate (audio rate) vs. k-rate in the Web Audio specification.
     void calculateFinalValues(float* values, unsigned numberOfValues, bool sampleAccurate);
     void calculateTimelineValues(float* values, unsigned numberOfValues);
 
     // The type of AudioParam, indicating what this AudioParam represents and what node it belongs
     // to.  Mostly for informational purposes and doesn't affect implementation.
     AudioParamType m_paramType;
 
     // Intrinsic value
     float m_intrinsicValue;
-    void setIntrinsicValue(float newValue) { noBarrierStore(&m_intrinsicValue, newValue); }
+    void setIntrinsicValue(float newValue);
 
     float m_defaultValue;
 
+    // Nominal range for the value
+    float m_minValue;
+    float m_maxValue;
+
     // Smoothing (de-zippering)
     float m_smoothedValue;
 
     AudioParamTimeline m_timeline;
 
     // The destination node used to get necessary information like the smaple rate and context time.
     RefPtr<AudioDestinationHandler> m_destinationHandler;
 };
 
 // AudioParam class represents web-exposed AudioParam interface.
 class AudioParam final : public GarbageCollectedFinalized<AudioParam>, public ScriptWrappable {
     DEFINE_WRAPPERTYPEINFO();
 public:
     static AudioParam* create(AbstractAudioContext&, AudioParamType, double defaultValue);
+    static AudioParam* create(AbstractAudioContext&, AudioParamType, double defaultValue, float min, float max);

[hongchan, 2016/05/13 01:30:15]

Here as well.

[Raymond Toy, 2016/05/13 18:40:32]

Done.

+
     DECLARE_TRACE();
     // |handler| always returns a valid object.
     AudioParamHandler& handler() const { return *m_handler; }
     // |context| always returns a valid object.
     AbstractAudioContext* context() const { return m_context; }
 
     AudioParamType getParamType() const { return handler().getParamType(); }
     String getParamName() const;
 
     float value() const;
     void setValue(float);
     float defaultValue() const;
+
+    float minValue() const;
+    float maxValue() const;
+
     AudioParam* setValueAtTime(float value, double time, ExceptionState&);
     AudioParam* linearRampToValueAtTime(float value, double time, ExceptionState&);
     AudioParam* exponentialRampToValueAtTime(float value, double time, ExceptionState&);
     AudioParam* setTargetAtTime(float target, double time, double timeConstant, ExceptionState&);
     AudioParam* setValueCurveAtTime(DOMFloat32Array* curve, double time, double duration, ExceptionState&);
     AudioParam* cancelScheduledValues(double startTime, ExceptionState&);
 
 private:
-    AudioParam(AbstractAudioContext&, AudioParamType, double defaultValue);
+    AudioParam(AbstractAudioContext&, AudioParamType, double defaultValue, float min, float max);

[hongchan, 2016/05/13 01:30:15]

Ditto.

[Raymond Toy, 2016/05/13 18:40:32]

Done.

+
+    void warnIfOutsideRange(float value, float minValue, float maxValue);
 
     RefPtr<AudioParamHandler> m_handler;
     Member<AbstractAudioContext> m_context;
 };
 
 } // namespace blink
 
 #endif // AudioParam_h