Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4036)

Unified Diff: chrome/browser/lifetime/keep_alive_registry.h

Issue 1803143002: Replace BrowserProces::AddRefModule/RemoveModule by ScopedKeepAlive (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/lifetime/keep_alive_registry.h
diff --git a/chrome/browser/lifetime/keep_alive_registry.h b/chrome/browser/lifetime/keep_alive_registry.h
index cd0d4128b71adb002eaae3d026523131524b328e..e894af93fe79195b528034abe102c7f83520342c 100644
--- a/chrome/browser/lifetime/keep_alive_registry.h
+++ b/chrome/browser/lifetime/keep_alive_registry.h
@@ -20,11 +20,9 @@ class KeepAliveRegistry {
static KeepAliveRegistry* GetInstance();
// Methods to query the state of the registry.
- // TODO(dgn): This currently does not give a complete picture. It has no
- // information about the many places that rely on AddRefModule to keep the
- // browser alive. Tracked by https://crbug.com/587926
bool IsKeepingAlive() const;
bool IsRestartAllowed() const;
+ bool IsOriginRegistered(KeepAliveOrigin origin) const;
dgn 2016/03/16 15:10:50 Should I rename it xxForTesting? I suppose it coul
sky 2016/03/17 00:02:24 I wouldn't bother.
void AddObserver(KeepAliveStateObserver* observer);
void RemoveObserver(KeepAliveStateObserver* observer);

Powered by Google App Engine
This is Rietveld 408576698