Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 1803143002: Replace BrowserProces::AddRefModule/RemoveModule by ScopedKeepAlive (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
index 63fc89b2d9703e67335f9000bcf837bb20c09e62..51b4e62d445d2086e34a77e5ba227897d91700cf 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
@@ -20,6 +20,8 @@
#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/first_run/first_run.h"
#include "chrome/browser/infobars/infobar_service.h"
+#include "chrome/browser/lifetime/keep_alive_types.h"
+#include "chrome/browser/lifetime/scoped_keep_alive.h"
#include "chrome/browser/prefs/session_startup_pref.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_impl.h"
@@ -270,7 +272,8 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest,
SessionStartupPref::SetStartupPref(profile, pref);
// Keep the browser process running while browsers are closed.
- g_browser_process->AddRefModule();
+ ScopedKeepAlive keep_alive(KeepAliveOrigin::BROWSER,
+ KeepAliveRestartOption::DISABLED);
// Close the browser.
CloseBrowserAsynchronously(browser());
@@ -330,8 +333,6 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest,
ASSERT_EQ(static_cast<int>(urls.size()),
new_browser->tab_strip_model()->count());
}
-
- g_browser_process->ReleaseModule();
}
// Verify that startup URLs aren't used when the process already exists

Powered by Google App Engine
This is Rietveld 408576698