Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7707)

Unified Diff: chrome/browser/sessions/session_restore_browsertest.cc

Issue 1803143002: Replace BrowserProces::AddRefModule/RemoveModule by ScopedKeepAlive (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/session_restore.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/session_restore_browsertest.cc
diff --git a/chrome/browser/sessions/session_restore_browsertest.cc b/chrome/browser/sessions/session_restore_browsertest.cc
index 80f41907f27fd79e9824048a571d6cbb24fc2d8e..43c7aaaab4d55c28891448a7a625f07294a29a65 100644
--- a/chrome/browser/sessions/session_restore_browsertest.cc
+++ b/chrome/browser/sessions/session_restore_browsertest.cc
@@ -15,9 +15,10 @@
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
#include "build/build_config.h"
-#include "chrome/browser/browser_process.h"
#include "chrome/browser/defaults.h"
#include "chrome/browser/first_run/first_run.h"
+#include "chrome/browser/lifetime/keep_alive_types.h"
+#include "chrome/browser/lifetime/scoped_keep_alive.h"
#include "chrome/browser/prefs/session_startup_pref.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
@@ -129,7 +130,8 @@ class SessionRestoreTest : public InProcessBrowserTest {
Profile* profile = browser->profile();
// Close the browser.
- g_browser_process->AddRefModule();
+ scoped_ptr<ScopedKeepAlive> keep_alive(new ScopedKeepAlive(
+ KeepAliveOrigin::SESSION_RESTORE, KeepAliveRestartOption::DISABLED));
CloseBrowserSynchronously(browser);
// Create a new window, which should trigger session restore.
@@ -154,7 +156,7 @@ class SessionRestoreTest : public InProcessBrowserTest {
if (no_memory_pressure)
WaitForTabsToLoad(new_browser);
- g_browser_process->ReleaseModule();
+ keep_alive.reset();
return new_browser;
}
@@ -1407,7 +1409,8 @@ IN_PROC_BROWSER_TEST_F(SmartSessionRestoreTest, PRE_CorrectLoadingOrder) {
browser()->tab_strip_model()->ActivateTabAt(i, true);
// Close the browser.
- g_browser_process->AddRefModule();
+ scoped_ptr<ScopedKeepAlive> keep_alive(new ScopedKeepAlive(
+ KeepAliveOrigin::SESSION_RESTORE, KeepAliveRestartOption::DISABLED));
CloseBrowserSynchronously(browser());
StartObserving(kExpectedNumTabs);
@@ -1418,7 +1421,7 @@ IN_PROC_BROWSER_TEST_F(SmartSessionRestoreTest, PRE_CorrectLoadingOrder) {
Browser* new_browser = window_observer.WaitForSingleNewBrowser();
ASSERT_TRUE(new_browser);
WaitForAllTabsToStartLoading();
- g_browser_process->ReleaseModule();
+ keep_alive.reset();
ASSERT_EQ(kExpectedNumTabs, web_contents().size());
// Test that we have observed the tabs being loaded in the inverse order of
@@ -1450,7 +1453,8 @@ IN_PROC_BROWSER_TEST_F(SmartSessionRestoreTest, MAYBE_CorrectLoadingOrder) {
// Close the browser that gets opened automatically so we can track the order
// of loading of the tabs.
- g_browser_process->AddRefModule();
+ scoped_ptr<ScopedKeepAlive> keep_alive(new ScopedKeepAlive(
+ KeepAliveOrigin::SESSION_RESTORE, KeepAliveRestartOption::DISABLED));
CloseBrowserSynchronously(browser());
// We have an extra tab that is added when the test starts, which gets ignored
// later when we test for proper order.
@@ -1462,7 +1466,7 @@ IN_PROC_BROWSER_TEST_F(SmartSessionRestoreTest, MAYBE_CorrectLoadingOrder) {
Browser* new_browser = window_observer.WaitForSingleNewBrowser();
ASSERT_TRUE(new_browser);
WaitForAllTabsToStartLoading();
- g_browser_process->ReleaseModule();
+ keep_alive.reset();
ASSERT_EQ(kExpectedNumTabs + 1, web_contents().size());
« no previous file with comments | « chrome/browser/sessions/session_restore.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698