Remove _BufferList from dart:io and now use BytesBuilder.

sdk/lib/io/http_impl.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 class _HttpIncoming extends Stream<List<int>> {
   final int _transferLength;
   final Completer _dataCompleter = new Completer();
   Stream<List<int>> _stream;
@@ skipping 632 matching lines @@
     _controller.close();
     return _closeCompleter.future.then((_) => closeOutbound());
   }
 }
 
 
 class _BufferTransformer extends StreamEventTransformer<List<int>, List<int>> {
   static const int MIN_CHUNK_SIZE = 4 * 1024;
   static const int MAX_BUFFER_SIZE = 16 * 1024;
 
-  final _BufferList _buffer = new _BufferList();
+  final BytesBuilder _builder = new BytesBuilder();
 
   void handleData(List<int> data, EventSink<List<int>> sink) {
     // TODO(ajohnsen): Use timeout?
     if (data.length == 0) return;
     if (data.length >= MIN_CHUNK_SIZE) {
       flush(sink);
       sink.add(data);
     } else {
-      _buffer.add(data);
-      if (_buffer.length >= MAX_BUFFER_SIZE) {
+      _builder.add(data);
+      if (_builder.length >= MAX_BUFFER_SIZE) {
         flush(sink);
       }
     }
   }
 
   void handleDone(EventSink<List<int>> sink) {
     flush(sink);
     sink.close();
   }
 
   void flush(EventSink<List<int>> sink) {
-    if (_buffer.length > 0) {
-      sink.add(_buffer.readBytes());
-      _buffer.clear();
+    if (_builder.length > 0) {
+      // takeBytes will clear the BytesBuilder.
+      sink.add(_builder.takeBytes());
     }
   }
 }
 
 
 class _HttpResponse extends _HttpOutboundMessage<HttpResponse>
     implements HttpResponse {
   int statusCode = 200;
   String _reasonPhrase;
   List<Cookie> _cookies;
@@ skipping 27 matching lines @@
     done.catchError((_) {
       // Catch any error on done, as they automatically will be
       // propagated to the websocket.
     });
     return future;
   }
 
   HttpConnectionInfo get connectionInfo => _httpRequest.connectionInfo;
 
   void _writeHeader() {
-    var buffer = new _BufferList();
-    writeSP() => buffer.add(const [_CharCode.SP]);
-    writeCRLF() => buffer.add(const [_CharCode.CR, _CharCode.LF]);
+    var builder = new BytesBuilder();
+    writeSP() => builder.add(const [_CharCode.SP]);
+    writeCRLF() => builder.add(const [_CharCode.CR, _CharCode.LF]);
 
     // Write status line.
     if (headers.protocolVersion == "1.1") {
-      buffer.add(_Const.HTTP11);
+      builder.add(_Const.HTTP11);
     } else {
-      buffer.add(_Const.HTTP10);
+      builder.add(_Const.HTTP10);
     }
     writeSP();
-    buffer.add(statusCode.toString().codeUnits);
+    builder.add(statusCode.toString().codeUnits);
     writeSP();
-    buffer.add(reasonPhrase.codeUnits);
+    builder.add(reasonPhrase.codeUnits);
     writeCRLF();
 
     var session = _httpRequest._session;
     if (session != null && !session._destroyed) {
       // Mark as not new.
       session._isNew = false;
       // Make sure we only send the current session id.
       bool found = false;
       for (int i = 0; i < cookies.length; i++) {
         if (cookies[i].name.toUpperCase() == _DART_SESSION_ID) {
@@ skipping 13 matching lines @@
     // Add all the cookies set to the headers.
     if (_cookies != null) {
       _cookies.forEach((cookie) {
         headers.add(HttpHeaders.SET_COOKIE, cookie);
       });
     }
 
     headers._finalize();
 
     // Write headers.
-    headers._write(buffer);
+    headers._write(builder);
     writeCRLF();
-    _headersSink.add(buffer.readBytes());
+    _headersSink.add(builder.takeBytes());
   }
 
   String _findReasonPhrase(int statusCode) {
     if (_reasonPhrase != null) {
       return _reasonPhrase;
     }
 
     switch (statusCode) {
       case HttpStatus.CONTINUE: return "Continue";
       case HttpStatus.SWITCHING_PROTOCOLS: return "Switching Protocols";
@@ skipping 175 matching lines @@
         if (_httpClientConnection._proxyTunnel) {
           return uriStartingFromPath();
         } else {
           return uri.toString();
         }
       }
     }
   }
 
   void _writeHeader() {
-    var buffer = new _BufferList();
+    var builder = new BytesBuilder();
 
-    writeSP() => buffer.add(const [_CharCode.SP]);
+    writeSP() => builder.add(const [_CharCode.SP]);
 
-    writeCRLF() => buffer.add(const [_CharCode.CR, _CharCode.LF]);
+    writeCRLF() => builder.add(const [_CharCode.CR, _CharCode.LF]);
 
     // Write the request method.
-    buffer.add(method.codeUnits);
+    builder.add(method.codeUnits);
     writeSP();
     // Write the request URI.
-    buffer.add(_requestUri().codeUnits);
+    builder.add(_requestUri().codeUnits);
     writeSP();
     // Write HTTP/1.1.
-    buffer.add(_Const.HTTP11);
+    builder.add(_Const.HTTP11);
     writeCRLF();
 
     // Add the cookies to the headers.
     if (!cookies.isEmpty) {
       StringBuffer sb = new StringBuffer();
       for (int i = 0; i < cookies.length; i++) {
         if (i > 0) sb.write("; ");
         sb.write(cookies[i].name);
         sb.write("=");
         sb.write(cookies[i].value);
       }
       headers.add(HttpHeaders.COOKIE, sb.toString());
     }
 
     headers._finalize();
 
     // Write headers.
-    headers._write(buffer);
+    headers._write(builder);
     writeCRLF();
-    _headersSink.add(buffer.readBytes());
+    _headersSink.add(builder.takeBytes());
   }
 }
 
 
 // Transformer that transforms data to HTTP Chunked Encoding.
 class _ChunkedTransformer extends StreamEventTransformer<List<int>, List<int>> {
   int _pendingFooter = 0;
 
   void handleData(List<int> data, EventSink<List<int>> sink) {
     sink.add(_chunkHeader(data.length));
@@ skipping 1390 matching lines @@
   final Uri location;
 }
 
 String _getHttpVersion() {
   var version = Platform.version;
   // Only include major and minor version numbers.
   int index = version.indexOf('.', version.indexOf('.') + 1);
   version = version.substring(0, index);
   return 'Dart/$version (dart:io)';
 }