Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 18031013: Fixes for frame proxy to avoid double output in layout tests. (Closed)

Created:
7 years, 5 months ago by nasko
Modified:
7 years, 5 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium
Visibility:
Public.

Description

Fixes for frame proxy to avoid double output in layout tests. Calling out to m_baseProxy and the base object results right now in duplicate prints, since the base object also calls into WebTestProxyBase. I'm removing the extra calls right now and will add them as I migrate methods from RenderView to RenderFrame. BUG=245126 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153250

Patch Set 1 #

Total comments: 4

Patch Set 2 : Moving pointer to initializer list. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -35 lines) Patch
M public/testing/WebFrameTestProxy.h View 1 3 chunks +12 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nasko
Hey Jochen, I didn't catch this earlier, but there are duplicate logs in some cases, ...
7 years, 5 months ago (2013-06-28 00:19:27 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/18031013/diff/1/public/testing/WebFrameTestProxy.h File public/testing/WebFrameTestProxy.h (right): https://codereview.chromium.org/18031013/diff/1/public/testing/WebFrameTestProxy.h#newcode46 public/testing/WebFrameTestProxy.h:46: m_baseProxy = 0; nit: move to initializer list ...
7 years, 5 months ago (2013-06-28 08:48:23 UTC) #2
nasko
https://codereview.chromium.org/18031013/diff/1/public/testing/WebFrameTestProxy.h File public/testing/WebFrameTestProxy.h (right): https://codereview.chromium.org/18031013/diff/1/public/testing/WebFrameTestProxy.h#newcode46 public/testing/WebFrameTestProxy.h:46: m_baseProxy = 0; On 2013/06/28 08:48:24, jochen wrote: > ...
7 years, 5 months ago (2013-06-28 15:12:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/18031013/6001
7 years, 5 months ago (2013-06-28 15:13:40 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-06-28 16:56:26 UTC) #5
Message was sent while issue was closed.
Change committed as 153250

Powered by Google App Engine
This is Rietveld 408576698