Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18031009: Use a direct include of time headers in rlz/, skia/, sql/, sync/. (Closed)

Created:
7 years, 5 months ago by Avi (use Gerrit)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, albertb+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of time headers in rlz/, skia/, sql/, sync/. BUG=254986 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M rlz/lib/financial_ping.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M rlz/lib/financial_ping_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/convolver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/image_operations.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/ext/image_operations_bench.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/recursive_gaussian_convolution_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/connection.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/backoff_delay_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/backoff_delay_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/sync_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/sync_scheduler_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/engine/syncer.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/syncer_proto_util.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/syncer_proto_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/syncer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/traffic_recorder.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/traffic_recorder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/base/invalidation.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/base_node.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/data_type_association_stats.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/engine/sync_status.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/sessions/sync_session_snapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/sync_encryption_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_encryption_handler_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_encryption_handler_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/internal_api/syncapi_server_connection_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/ack_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/notifier/registration_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/notifier/sync_invalidation_listener_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/protocol/proto_value_conversions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/sessions/data_type_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/sessions/status_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/sessions/sync_session.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/directory_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/entry_kernel.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/accounts_client/test_accounts_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/data_type_histogram.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/data_type_histogram_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/time.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/18031009/1
7 years, 5 months ago (2013-06-27 22:04:59 UTC) #1
Avi (use Gerrit)
7 years, 5 months ago (2013-06-28 15:22:07 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r209152 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698