Stop printing when stdout is closed.

runtime/bin/eventhandler_android.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_ANDROID)
 
 #include "bin/eventhandler.h"
 
 #include <errno.h>  // NOLINT
@@ skipping 197 matching lines @@
         ASSERT(msg.data == (1 << kShutdownWriteCommand));
         // Close the socket for writing.
         sd->ShutdownWrite();
         UpdateEpollInstance(epoll_fd_, sd);
       } else if ((msg.data & (1 << kCloseCommand)) != 0) {
         ASSERT(msg.data == (1 << kCloseCommand));
         // Close the socket and free system resources and move on to
         // next message.
         RemoveFromEpollInstance(epoll_fd_, sd);
         intptr_t fd = sd->fd();
-        sd->Close();
+        if (fd == STDOUT_FILENO) {
+          // If stdout, redirect fd to /dev/null.
+          USE(dup2(open("/dev/null", O_WRONLY), STDOUT_FILENO));

[kustermann, 2013/06/27 15:14:07]

You leak one file descriptor here. I'd do something like:

// Close the old stdout descriptor and replace it with /dev/null.
int nullFd = TEMP_FAILURE_RETRY(open("/dev/null", O_WRONLY));
ASSERT(nullFd >= 0);
VOID_TEMP_FAILURE_RETRY(dup2(nullFd, STDOUT_FILENO));
VOID_TEMP_FAILURE_RETRY(close(nullFd));

Note the last line. After dup2()'ing you've got two identical file descriptors
(one in nullFd and one in STDOUT_FILENO) so we need to close 'nullFd'.

[Anders Johnsen, 2013/06/27 16:32:07]

You're right, thanks!

+        } else {

[Bill Hesse, 2013/06/27 16:42:36]

Shouldn't you be checking that dev/null didn't open on STDOUT_FILENO, if you
close it?

[Anders Johnsen, 2013/06/27 16:44:11]

No, it's still open at this point.

+          sd->Close();
+        }
         socket_map_.Remove(GetHashmapKeyFromFd(fd), GetHashmapHashFromFd(fd));
         delete sd;
       } else {
         // Setup events to wait for.
         sd->SetPortAndMask(msg.dart_port, msg.data);
         UpdateEpollInstance(epoll_fd_, sd);
       }
     }
   }
 }
@@ skipping 198 matching lines @@
 
 uint32_t EventHandlerImplementation::GetHashmapHashFromFd(intptr_t fd) {
   // The hashmap does not support keys with value 0.
   return dart::Utils::WordHash(fd + 1);
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_ANDROID)