Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 180303003: Add some missing setlocals from various .bat files (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 10 months ago
Reviewers:
gab, iannucci, johnw1, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, grt (UTC plus 2)
Visibility:
Public.

Description

Add some missing setlocals from various .bat files Shell PATH was growing quite long in some cases. R=gab@chromium.org, iannucci@chromium.org, johnw@chromium.org, maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M apply_issue.bat View 1 chunk +1 line, -0 lines 0 comments Download
M clang-format.bat View 1 chunk +1 line, -0 lines 0 comments Download
M fetch.bat View 1 chunk +1 line, -0 lines 0 comments Download
M gclient.bat View 1 chunk +1 line, -0 lines 0 comments Download
M gn.bat View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
scottmg
maruel: for review others who have been on previous reviews of these files to make ...
6 years, 10 months ago (2014-02-25 20:47:36 UTC) #1
gab
Ah Batch, we love thee.... lgtm (CC:grt, the only Batch "expert" I know).
6 years, 10 months ago (2014-02-25 21:56:17 UTC) #2
scottmg
On 2014/02/25 21:56:17, gab wrote: > Ah Batch, we love thee.... lgtm (CC:grt, the only ...
6 years, 10 months ago (2014-02-25 22:02:27 UTC) #3
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 10 months ago (2014-02-25 22:02:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/180303003/1
6 years, 10 months ago (2014-02-25 22:02:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 22:02:42 UTC) #6
commit-bot: I haz the power
Failed to apply patch for depot_tools/apply_issue.bat: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-25 22:02:43 UTC) #7
scottmg
The CQ bit was unchecked by scottmg@chromium.org
6 years, 10 months ago (2014-02-25 22:02:52 UTC) #8
gab
On 2014/02/25 22:02:43, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
6 years, 10 months ago (2014-02-25 22:07:39 UTC) #9
scottmg
Apparently I still need an OWNERS too (maruel or iannucci looking promising)
6 years, 10 months ago (2014-02-25 22:19:13 UTC) #10
iannucci
'lgtm'
6 years, 10 months ago (2014-02-25 22:26:24 UTC) #11
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 10 months ago (2014-02-25 22:26:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/180303003/1
6 years, 10 months ago (2014-02-25 22:27:10 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 22:27:12 UTC) #14
commit-bot: I haz the power
Failed to apply patch for depot_tools/apply_issue.bat: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-25 22:27:12 UTC) #15
scottmg
6 years, 10 months ago (2014-02-26 04:07:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 manually as r253347 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698