Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1802983002: [test] Remove feature to mark flaky tests. (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Remove feature to mark flaky tests. The feature was removed from the bots a while ago. It was superseeded by the flaky-test detection which reruns tests. Remaining tests still marked as flaky most certainly pass since a while. Referencing all the bugs whose expectations lines get removed by this. BUG=v8:3838, v8:3525, v8:3125 LOG=n Committed: https://crrev.com/7f363d5d47e98711900d44c0910819eb3455e814 Cr-Commit-Position: refs/heads/master@{#34804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -47 lines) Patch
M test/cctest/cctest.status View 4 chunks +0 lines, -20 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/run-tests.py View 5 chunks +3 lines, -9 lines 0 comments Download
M tools/testrunner/local/statusfile.py View 3 chunks +1 line, -6 lines 0 comments Download
M tools/testrunner/local/testsuite.py View 4 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802983002/1
4 years, 9 months ago (2016-03-15 14:07:49 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 14:31:58 UTC) #4
Michael Achenbach
PTAL
4 years, 9 months ago (2016-03-15 14:39:32 UTC) #8
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-15 17:22:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802983002/1
4 years, 9 months ago (2016-03-16 07:32:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 07:34:21 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 07:35:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f363d5d47e98711900d44c0910819eb3455e814
Cr-Commit-Position: refs/heads/master@{#34804}

Powered by Google App Engine
This is Rietveld 408576698