src/pdf/SkPDFDocument.cpp - Issue 1802963002: SkPDF: SkPDFDevice has ptr to SkPDFDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFDocument.cpp

Issue 1802963002: SkPDF: SkPDFDevice has ptr to SkPDFDocument (Closed) Base URL: https://skia.googlesource.com/skia.git@SkPdfBigSerializeRefactor

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFDocument.cpp

diff --git a/src/pdf/SkPDFDocument.cpp b/src/pdf/SkPDFDocument.cpp

index 057631edf1a41e69a6135ec043780992bf75b55d..70c09595f9ab712f2a2b12114b86a1559fdc7e4e 100644

--- a/src/pdf/SkPDFDocument.cpp

+++ b/src/pdf/SkPDFDocument.cpp

@@ -272,7 +272,7 @@ SkCanvas* SkPDFDocument::onBeginPage(SkScalar width, SkScalar height,

SkISize pageSize = SkISize::Make(

SkScalarRoundToInt(width), SkScalarRoundToInt(height));

sk_sp<SkPDFDevice> device(

- SkPDFDevice::Create(pageSize, fRasterDpi, &fCanon));

+ SkPDFDevice::Create(pageSize, fRasterDpi, this));

fCanvas.reset(new SkCanvas(device.get()));

fPageDevices.push_back(std::move(device));

fCanvas->clipRect(trimBox);