SkPDF: SkPDFDevice has ptr to SkPDFDocument

SkPDF: SkPDFDevice has ptr to SkPDFDocument

This is necessary for pre-serialization of images.

BUG=skia:5087
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1802963002

Committed: https://skia.googlesource.com/skia/+/989da4a32cd6823359f31c971c3b3f31425e905e

[hal.canary, 2016-03-15 12:47:49]

Description was changed from

==========
SkPDF: SkPDFDevice has ptr to SkPDFDocument

This is necessary for pre-serialization of images.

BUG=skia:5087
==========

to

==========
SkPDF: SkPDFDevice has ptr to SkPDFDocument

This is necessary for pre-serialization of images.

BUG=skia:5087
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-03-15 12:48:45]

This CL depends on https://crrev.com/1802033003

Please review that first.

[hal.canary, 2016-03-15 12:49:20]

halcanary@google.com changed reviewers:
+ tomhudson@google.com

[hal.canary, 2016-03-15 12:49:20]

This CL depends on https://crrev.com/1802033003

Please review that first.

[tomhudson, 2016-03-21 14:49:48]

Not sure I like the direction of this change. 95% of the use of fDocument is
just to call fDocument->getCanon(), when we used to pass in the SkPDFCanon
directly.

The only necessary use of a Document that I see is in the early serialization
code. Could there perhaps be a better place to hang *that* function call, on
Canon or Document or ...?

https://codereview.chromium.org/1802963002/diff/1/src/pdf/SkPDFDevice.h
File src/pdf/SkPDFDevice.h (right):

https://codereview.chromium.org/1802963002/diff/1/src/pdf/SkPDFDevice.h#newco...
src/pdf/SkPDFDevice.h:64: *         devices in a document.
This comment doesn't explain to me why. In the old days I might have been able
to go read SkPDFCanon.h and figure out why there was one being provided, but now
I have no clue unless I git into the code far enough that I realize the Canon
off of this Document is being returned by getCanon() and I need to know what
that canon is; even that isn't sufficient for me to know if it's the *only*
reason this Document is being provided.

[hal.canary, 2016-03-21 21:06:02]

https://codereview.chromium.org/1802963002/diff/1/src/pdf/SkPDFDevice.h
File src/pdf/SkPDFDevice.h (right):

https://codereview.chromium.org/1802963002/diff/1/src/pdf/SkPDFDevice.h#newco...
src/pdf/SkPDFDevice.h:64: *         devices in a document.
On 2016/03/21 14:49:48, tomhudson wrote:
> This comment doesn't explain to me why. In the old days I might have been able
> to go read SkPDFCanon.h and figure out why there was one being provided, but
now
> I have no clue unless I git into the code far enough that I realize the Canon
> off of this Document is being returned by getCanon() and I need to know what
> that canon is; even that isn't sufficient for me to know if it's the *only*
> reason this Document is being provided.

better?

@param SkPDFDocument.  A non-null pointer back to the
       document.  The document is repsonsible for
       de-duplicating across pages (via the SkPDFCanon) and
       for early serializing of large immutable objects, such
       as images (via SkPDFDocument::serialize()).

[tomhudson, 2016-03-21 21:09:56]

https://codereview.chromium.org/1802963002/diff/1/src/pdf/SkPDFDevice.h
File src/pdf/SkPDFDevice.h (right):

https://codereview.chromium.org/1802963002/diff/1/src/pdf/SkPDFDevice.h#newco...
src/pdf/SkPDFDevice.h:64: *         devices in a document.
On 2016/03/21 21:06:02, Hal Canary wrote:
> better?
> ...

Yes, thanks.

[tomhudson, 2016-03-21 21:17:47]

OK, I can't think of a better way, and solely because of that LGTM.

[hal.canary, 2016-03-21 21:23:28]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-03-21 21:23:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1802963002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1802963002/20001

[commit-bot: I haz the power, 2016-03-21 21:33:20]

Description was changed from

==========
SkPDF: SkPDFDevice has ptr to SkPDFDocument

This is necessary for pre-serialization of images.

BUG=skia:5087
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkPDF: SkPDFDevice has ptr to SkPDFDocument

This is necessary for pre-serialization of images.

BUG=skia:5087
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/989da4a32cd6823359f31c971c3b3f31425e905e
==========

[commit-bot: I haz the power, 2016-03-21 21:33:22]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/989da4a32cd6823359f31c971c3b3f31425e905e