third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h - Issue 1802953003: RemoteBridgeFrameOwner: keep better track of the attached frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

Issue 1802953003: RemoteBridgeFrameOwner: keep better track of the attached frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't call virtuals indirectly from a ctor. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/RemoteFrame.cpp ('K') | « third_party/WebKit/Source/core/frame/RemoteFrame.cpp ('k') | third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp » ('j') | third_party/WebKit/Source/web/WebFrame.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

index 576bab5bd3b7c1fcc3dd0a2b52ce19202b6aaa5c..8f65ff59009bf7709a2f5a56210b2f2037ae9a8b 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

@@ -47,9 +47,6 @@ public:

DOMWindow* contentWindow() const;

Document* contentDocument() const;

- void setContentFrame(Frame&);

- void clearContentFrame();

void disconnectContentFrame();

// Most subclasses use LayoutPart (either LayoutEmbeddedObject or LayoutIFrame)

@@ -78,6 +75,8 @@ public:

// FrameOwner overrides:

bool isLocal() const override { return true; }

+ void setContentFrame(Frame&) override;

+ void clearContentFrame() override;

void dispatchLoad() override;

SandboxFlags getSandboxFlags() const override { return m_sandboxFlags; }

void renderFallbackContent() override { }