third_party/WebKit/Source/core/frame/RemoteFrame.h - Issue 1802953003: RemoteBridgeFrameOwner: keep better track of the attached frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/RemoteFrame.h

Issue 1802953003: RemoteBridgeFrameOwner: keep better track of the attached frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't call virtuals indirectly from a ctor. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/FrameOwner.h ('K') | « third_party/WebKit/Source/core/frame/FrameOwner.h ('k') | third_party/WebKit/Source/core/frame/RemoteFrame.cpp » ('j') | third_party/WebKit/Source/core/frame/RemoteFrame.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/RemoteFrame.h

diff --git a/third_party/WebKit/Source/core/frame/RemoteFrame.h b/third_party/WebKit/Source/core/frame/RemoteFrame.h

index d24a3ba5fe44da4182703deebc84a91fa5e89f97..f7d23fbb00ad96f1034254aef35000fb708b042f 100644

--- a/third_party/WebKit/Source/core/frame/RemoteFrame.h

+++ b/third_party/WebKit/Source/core/frame/RemoteFrame.h

@@ -39,7 +39,6 @@ public:

void detach(FrameDetachType) override;

RemoteSecurityContext* securityContext() const override;

void printNavigationErrorMessage(const Frame&, const char* reason) override { }

- void disconnectOwnerElement() override;

bool prepareForCommit() override;

bool shouldClose() override;