Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 180293002: Add a test for template contents handling in importNode (Closed)

Created:
6 years, 9 months ago by rwlbuis
Modified:
6 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add a test for template contents handling in importNode Add a test for template contents handling in importNode, I missed this as part of: https://codereview.chromium.org/173303004/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167871

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
A LayoutTests/fast/dom/HTMLTemplateElement/importNode.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLTemplateElement/importNode-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rwlbuis
Sorry for not including this in CL 173303004. I verified that the testcase fails without ...
6 years, 9 months ago (2014-02-25 19:48:45 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-02-25 21:57:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/180293002/1
6 years, 9 months ago (2014-02-25 21:58:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/180293002/1
6 years, 9 months ago (2014-02-25 23:08:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/180293002/1
6 years, 9 months ago (2014-02-25 23:26:41 UTC) #5
Paweł Hajdan Jr.
The CQ bit was unchecked by phajdan.jr@chromium.org
6 years, 9 months ago (2014-02-26 05:45:31 UTC) #6
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 9 months ago (2014-02-26 06:01:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/180293002/1
6 years, 9 months ago (2014-02-26 06:06:26 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-02-26 09:09:20 UTC) #9
Message was sent while issue was closed.
Change committed as 167871

Powered by Google App Engine
This is Rietveld 408576698