dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart - Issue 18029018: Check that non-abstract classes implement all methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart

Issue 18029018: Check that non-abstract classes implement all methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart b/dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart

index 2e98925a21c83a16ceb5894176c248d04712195d..5fb15e5c81eff8c0aec498a3214cfc2eee662845 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart

@@ -1312,6 +1312,11 @@ class AbstractFieldElementX extends ElementX implements AbstractFieldElement {

}

accept(ElementVisitor visitor) => visitor.visitAbstractFieldElement(this);

+ bool get isAbstract {

+ return getter != null && getter.isAbstract

+ || setter != null && setter.isAbstract;

+ }

}

// TODO(johnniwinther): [FunctionSignature] should be merged with

« no previous file with comments | « no previous file | dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart » ('j') | no next file with comments »