Issue 1802883002: Use JS backend in serialization_analysis_test

Issue 1802883002: Use JS backend in serialization_analysis_test (Closed)

Created:
4 years, 9 months ago by Johnni Winther

Modified:
4 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use JS backend in serialization_analysis_test BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/cc8aa23c16eb300b1cdcfd5f35c8a68c9ccb8ebc Reverted: https://github.com/dart-lang/sdk/commit/408f4edee375e7b207215ed9b6b5b2e7a813e243 Committed: https://github.com/dart-lang/sdk/commit/37ad6d2d1425003437e8ed78707587771b93a456

Patch Set 2 : Skip unnamed mixin applications in findExtendsNameOfClass. #

Patch Set 3 : Serialize ClassElement.isUnnamedMixinApplication and test added properties. #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -74 lines)			Patch
M	pkg/compiler/lib/src/common/resolution.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/compiler.dart	View		3 chunks	+13 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/elements/common.dart	View		2 chunks	+14 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/elements/modelx.dart	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	pkg/compiler/lib/src/enqueue.dart	View		1 chunk	+2 lines, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/native/enqueue.dart	View	1	2 chunks	+13 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/serialization/element_serialization.dart	View	1 2	10 chunks	+67 lines, -15 lines	0 comments	Download
M	pkg/compiler/lib/src/serialization/keys.dart	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/serialization/modelz.dart	View	1 2	6 chunks	+35 lines, -7 lines	0 comments	Download
M	tests/compiler/dart2js/serialization_analysis_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/serialization_test.dart	View	1 2	3 chunks	+24 lines, -27 lines	0 comments	Download

Messages

Total messages: 10 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Siggi Cherem (dart-lang)

lgtm! https://codereview.chromium.org/1802883002/diff/1/pkg/compiler/lib/src/serialization/element_serialization.dart File pkg/compiler/lib/src/serialization/element_serialization.dart (right): https://codereview.chromium.org/1802883002/diff/1/pkg/compiler/lib/src/serialization/element_serialization.dart#newcode159 pkg/compiler/lib/src/serialization/element_serialization.dart:159: compilationUnits.addAll(element.implementation.compilationUnits.toList()); let's chat more on this - initially ...

4 years, 9 months ago (2016-03-16 17:27:22 UTC) #3

Johnni Winther

Committed patchset #1 (id:1) manually as cc8aa23c16eb300b1cdcfd5f35c8a68c9ccb8ebc (presubmit successful).

4 years, 9 months ago (2016-03-17 08:23:38 UTC) #5

Johnni Winther

PTAL. Needed to revert and fix 'findExtendsNameOfClass'.

4 years, 9 months ago (2016-03-17 10:04:45 UTC) #7

Johnni Winther

4 years, 9 months ago (2016-03-18 06:57:37 UTC) #10

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
37ad6d2d1425003437e8ed78707587771b93a456 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages