Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1802753002: cc: Correctly inherit clip parent's clip in target space (Closed)

Created:
4 years, 9 months ago by weiliangc
Modified:
4 years, 9 months ago
Reviewers:
ajuma
CC:
cc-bugs_chromium.org, chromium-reviews, enne (OOO), Ian Vollick, jaydasika
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Correctly inherit clip parent's clip in target space When a clip is created by a render surface, it uses only parent clip. When this render surface doesn't apply clip, this clip node should inherit parent clip's |clip_in_target_space| adjusted to current target space. R=ajuma BUG=594675 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/0b41eafc7e1265b86c8be6f559e1d33a31b3621f Cr-Commit-Position: refs/heads/master@{#381080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M cc/trees/draw_property_utils.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
weiliangc
Please take a look.
4 years, 9 months ago (2016-03-14 20:36:48 UTC) #2
ajuma
lgtm
4 years, 9 months ago (2016-03-14 20:44:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802753002/1
4 years, 9 months ago (2016-03-14 20:45:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 21:36:04 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 21:37:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b41eafc7e1265b86c8be6f559e1d33a31b3621f
Cr-Commit-Position: refs/heads/master@{#381080}

Powered by Google App Engine
This is Rietveld 408576698