Keep dedicated layers for hiding animation

ui/views/corewm/window_animations.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_COREWM_WINDOW_ANIMATIONS_H_
 #define UI_VIEWS_COREWM_WINDOW_ANIMATIONS_H_
 
 #include <vector>
 
+#include "base/memory/scoped_ptr.h"
 #include "ui/views/views_export.h"
 
 namespace aura {
 class Window;
 }
 namespace base {
 class TimeDelta;
 }
 namespace gfx {
 class Rect;
 }
 namespace ui {
 class ImplicitAnimationObserver;
 class Layer;
 class LayerAnimationSequence;
+class ScopedLayerAnimationSettings;
 }
 
 namespace views {
 namespace corewm {
 
 // A variety of canned animations for window transitions.
 enum WindowVisibilityAnimationType {
   WINDOW_VISIBILITY_ANIMATION_TYPE_DEFAULT = 0,     // Default. Lets the system
                                                     // decide based on window
                                                     // type.
@@ skipping 39 matching lines @@
     aura::Window* window,
     const base::TimeDelta& duration);
 
 VIEWS_EXPORT base::TimeDelta GetWindowVisibilityAnimationDuration(
     const aura::Window& window);
 
 VIEWS_EXPORT void SetWindowVisibilityAnimationVerticalPosition(
     aura::Window* window,
     float position);
 
-// Creates an ImplicitAnimationObserver that takes ownership of the layers
-// associated with a Window so that the animation can continue after the Window
-// has been destroyed.
-// The returned object deletes itself when the animations are done.
-VIEWS_EXPORT ui::ImplicitAnimationObserver* CreateHidingWindowAnimationObserver(
-    aura::Window* window);
+
+// A scoped object which detaches the current layers which will animate and
+// recreates new layers for the window. Layers are owned by the animation
+// observer that is added to the deteached layer's animator, and will be deleted
+// when the animation is completed.
+class LayerDetacherForHidingAnimation {
+ public:
+  LayerDetacherForHidingAnimation() {}
+  virtual ~LayerDetacherForHidingAnimation() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(LayerDetacherForHidingAnimation);
+};
+
+// This has to be called before applying animations to |settings| because

[sky, 2014/03/10 13:30:40]

Is there anyway to this has been called before applying animations?

[oshima, 2014/03/10 17:48:24]

Not sure if I understood your question correctly.
If you change the properties on layers, it's too late to call this because the
animation is already scheduled by the |settings| and you can't observer them.

+// this will install animation observer.

[sky, 2014/03/10 13:30:40]

an animation observer

[oshima, 2014/03/10 17:48:24]

Done.

+VIEWS_EXPORT scoped_ptr<LayerDetacherForHidingAnimation>
+    DetachAndRecreateLayersForHidingAnimation(
+        aura::Window* window,
+        ui::ScopedLayerAnimationSettings* settings);
+
+// This installs a window observer that takes ownership of the layers
+// associated with a |winddow| so that the hiding animation can continue

[sky, 2014/03/10 13:30:40]

'a |winddow|' -> "window"

[oshima, 2014/03/10 17:48:24]

Done.

+// after the window has been destroyed.
+VIEWS_EXPORT void DetachLayersForHidingAnimationWhenDestroyed(
+    aura::Window* window,
+    ui::ScopedLayerAnimationSettings* settings);
 
 // Returns false if the |window| didn't animate.
 VIEWS_EXPORT bool AnimateOnChildWindowVisibilityChanged(aura::Window* window,
                                                         bool visible);
 VIEWS_EXPORT bool AnimateWindow(aura::Window* window, WindowAnimationType type);
 
 // Returns true if window animations are disabled for |window|. Window
 // animations are enabled by default. If |window| is NULL, this just checks
 // if the global flag disabling window animations is present.
 VIEWS_EXPORT bool WindowAnimationsDisabled(aura::Window* window);
 
 }  // namespace corewm
 }  // namespace views
 
 #endif  // UI_VIEWS_COREWM_WINDOW_ANIMATIONS_H_