Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 180273022: Don't deallocate the HashTable backing explicitly when it is managed by GC. (Closed)

Created:
6 years, 9 months ago by Vyacheslav Egorov (Chromium)
Modified:
6 years, 9 months ago
CC:
blink-reviews, Mikhail, adamk+blink_chromium.org, Inactive, abarth-chromium
Visibility:
Public.

Description

Don't deallocate the HashTable backing explicitly when it is managed by GC. This leads to double finalization. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168467

Patch Set 1 #

Total comments: 1

Patch Set 2 : address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/wtf/HashTable.h View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Vyacheslav Egorov (Chromium)
PTAL
6 years, 9 months ago (2014-03-04 13:52:39 UTC) #1
zerny-chromium
lgtm
6 years, 9 months ago (2014-03-04 14:02:05 UTC) #2
tkent
lgtm https://codereview.chromium.org/180273022/diff/1/Source/wtf/HashTable.h File Source/wtf/HashTable.h (right): https://codereview.chromium.org/180273022/diff/1/Source/wtf/HashTable.h#newcode283 Source/wtf/HashTable.h:283: if (!Allocator::isGarbageCollected) { nit: We prefer early return. ...
6 years, 9 months ago (2014-03-05 01:12:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vegorov@chromium.org/180273022/1
6 years, 9 months ago (2014-03-05 01:14:36 UTC) #4
wibling-chromium
lgtm
6 years, 9 months ago (2014-03-05 08:40:13 UTC) #5
Erik Corry
lgtm
6 years, 9 months ago (2014-03-05 08:42:00 UTC) #6
haraken
LGTM
6 years, 9 months ago (2014-03-05 08:44:22 UTC) #7
Vyacheslav Egorov (Chromium)
The CQ bit was unchecked by vegorov@chromium.org
6 years, 9 months ago (2014-03-05 11:38:00 UTC) #8
Vyacheslav Egorov (Chromium)
The CQ bit was checked by vegorov@chromium.org
6 years, 9 months ago (2014-03-05 11:41:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vegorov@chromium.org/180273022/20001
6 years, 9 months ago (2014-03-05 11:41:13 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 11:41:28 UTC) #11
Message was sent while issue was closed.
Change committed as 168467

Powered by Google App Engine
This is Rietveld 408576698