Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 180273021: Oilpan: fix tracing of KeyframeVector which is a HeapVector of Members. (Closed)

Created:
6 years, 9 months ago by Mads Ager (chromium)
Modified:
6 years, 9 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers, oilpan-reviews
Visibility:
Public.

Description

Oilpan: fix tracing of KeyframeVector which is a HeapVector of Members. The HeapVector was put in a normal Vector of pairs on the stack which is not traced. This issue was found with the ASAN build on layout tests. R=erik.corry@gmail.com, haraken@chromium.org, wibling@chromium.org, zerny@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168386

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/animation/css/CSSAnimations.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Mads Ager (chromium)
6 years, 9 months ago (2014-03-04 12:43:55 UTC) #1
Erik Corry
lgtm https://codereview.chromium.org/180273021/diff/1/Source/core/animation/css/CSSAnimations.cpp File Source/core/animation/css/CSSAnimations.cpp (right): https://codereview.chromium.org/180273021/diff/1/Source/core/animation/css/CSSAnimations.cpp#newcode97 Source/core/animation/css/CSSAnimations.cpp:97: HeapVector<std::pair<KeyframeEffectModel::KeyframeVector, RefPtr<TimingFunction> > >& keyframesAndTimingFunctions) WillBeHeapVector?
6 years, 9 months ago (2014-03-04 12:45:11 UTC) #2
haraken
LGTM with erik's comment. ASAN build is awesome :)
6 years, 9 months ago (2014-03-04 12:46:59 UTC) #3
Mads Ager (chromium)
https://codereview.chromium.org/180273021/diff/1/Source/core/animation/css/CSSAnimations.cpp File Source/core/animation/css/CSSAnimations.cpp (right): https://codereview.chromium.org/180273021/diff/1/Source/core/animation/css/CSSAnimations.cpp#newcode97 Source/core/animation/css/CSSAnimations.cpp:97: HeapVector<std::pair<KeyframeEffectModel::KeyframeVector, RefPtr<TimingFunction> > >& keyframesAndTimingFunctions) On 2014/03/04 12:45:12, Erik ...
6 years, 9 months ago (2014-03-04 12:49:06 UTC) #4
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-04 12:51:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/180273021/20001
6 years, 9 months ago (2014-03-04 12:51:27 UTC) #6
wibling-chromium
lgtm
6 years, 9 months ago (2014-03-04 13:04:56 UTC) #7
zerny-chromium
lgtm
6 years, 9 months ago (2014-03-04 13:06:06 UTC) #8
Mads Ager (chromium)
The CQ bit was unchecked by ager@chromium.org
6 years, 9 months ago (2014-03-04 14:00:21 UTC) #9
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-04 14:00:28 UTC) #10
Mads Ager (chromium)
The CQ bit was unchecked by ager@chromium.org
6 years, 9 months ago (2014-03-04 14:24:20 UTC) #11
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-04 14:24:24 UTC) #12
Mads Ager (chromium)
6 years, 9 months ago (2014-03-04 14:29:24 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 manually as r168386 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698