chrome/test/remoting/http_server/clientpage.html - Issue 180273015: Simple HTTP server for Chromoting End-to-End tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/remoting/http_server/clientpage.html

Issue 180273015: Simple HTTP server for Chromoting End-to-End tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing initial code review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>
	Jamie 2014/03/04 21:40:35 Please add a standard HTML header, including copyr Please add a standard HTML header, including copyright: <!doctype html> <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved. Use of this source code is governed by a BSD-style license that can be found in the LICENSE file. --> chaitali 2014/03/05 22:02:22 Done. Show quoted text On 2014/03/04 21:40:35, Jamie wrote: > Please add a standard HTML header, including copyright: > > <!doctype html> > <!-- > Copyright (c) 2012 The Chromium Authors. All rights reserved. > Use of this source code is governed by a BSD-style license that can be > found in the LICENSE file. > --> > Done.
	2 <head>
	Jamie 2014/03/04 21:40:35 Nit: 2-space indentation for <head> and <body> rel Nit: 2-space indentation for <head> and <body> relative to <html> chaitali 2014/03/05 22:02:22 Done. Show quoted text On 2014/03/04 21:40:35, Jamie wrote: > Nit: 2-space indentation for <head> and <body> relative to <html> Done.
	3 <title>Client Page</title>

	4 <script src="/static/clientpage.js"></script>
	Jamie 2014/03/04 21:40:35 Assuming the scripts are going to be collocated wi Assuming the scripts are going to be collocated with the pages, this should be a relative path, i.e. just "clientpage.js". chaitali 2014/03/05 22:02:22 Done. Show quoted text On 2014/03/04 21:40:35, Jamie wrote: > Assuming the scripts are going to be collocated with the pages, this should be a > relative path, i.e. just "clientpage.js". Done.
	5 </head>

	6 <body>

	7 </body>

	8 </html>

OLD	NEW

« no previous file with comments | « no previous file | chrome/test/remoting/http_server/clientpage.js » ('j') | chrome/test/remoting/http_server/clientpage.js » ('J')