chrome/test/remoting/http_server/hostpage.html - Issue 180273015: Simple HTTP server for Chromoting End-to-End tests

Side by Side Diff: chrome/test/remoting/http_server/hostpage.html

Issue 180273015: Simple HTTP server for Chromoting End-to-End tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/remoting/http_server/clientpage.html ('K') | « chrome/test/remoting/http_server/clientpage.html ('k') | chrome/test/remoting/http_server/http_server.py » ('j') | chrome/test/remoting/http_server/http_server.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <title>Host Page</title>

	4 <link rel="stylesheet" href="//yui.yahooapis.com/pure/0.4.2/pure-min.css">
	Jamie 2014/03/03 20:56:16 See above re: external URLs. See above re: external URLs. chaitali 2014/03/04 19:33:45 Done. Show quoted text On 2014/03/03 20:56:16, Jamie wrote: > See above re: external URLs. Done.
	5 <script src="//ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></sc ript>

	6 </head>

	7 <body>

	8 <div class="splash">
	anandc 2014/03/03 21:10:03 Indent by 2 spaces: http://google-styleguide.googl Indent by 2 spaces: http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml?showone=In... Here and elsewhere. chaitali 2014/03/04 19:33:45 Done. Show quoted text On 2014/03/03 21:10:03, anandc wrote: > Indent by 2 spaces: > http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml?showone=In... > Here and elsewhere. Done.
	9 <form class="pure-form pure-form-stacked">

	10 <fieldset>

	11 <center><textarea id="testtext" rows="10" cols="50" ></textarea></cent er>
	weitao 2014/03/03 21:33:42 Since you rely on tabbing to select the input cont Since you rely on tabbing to select the input control (see your other CL), please add tab order to make it more explicit. chaitali 2014/03/04 19:33:45 Done. Show quoted text On 2014/03/03 21:33:42, weitaosu wrote: > Since you rely on tabbing to select the input control (see your other CL), > please add tab order to make it more explicit. Done.
	12 </fieldset>

	13 </form>

	14 </div>

	15 <script>
	Jamie 2014/03/03 20:56:16 As with the client page, please pull out the JS in As with the client page, please pull out the JS into a separate file. chaitali 2014/03/04 19:33:45 Done. Show quoted text On 2014/03/03 20:56:16, Jamie wrote: > As with the client page, please pull out the JS into a separate file. Done.
	16 $("#testtext").keypress(function(e) {

	17 if ( e.which == 13 ) {
	Jamie 2014/03/03 20:56:16 Nit: No space after '(' or before ')'. Nit: No space after '(' or before ')'. anandc 2014/03/03 21:10:03 Comment indicating 13 == carriage return Comment indicating 13 == carriage return chaitali 2014/03/04 19:33:45 Done. Show quoted text On 2014/03/03 20:56:16, Jamie wrote: > Nit: No space after '(' or before ')'. Done. chaitali 2014/03/04 19:33:45 Done. Show quoted text On 2014/03/03 21:10:03, anandc wrote: > Comment indicating 13 == carriage return Done.
	18 var testTextVal = $("#testtext").val();

	19 var request = $.ajax({

	20 type: "POST",

	21 url: "/keytest/test",

	22 data: { text: testTextVal }

	23 });

	24 request.done(function() {

	25 console.log("Sent XHR!");
	Jamie 2014/03/03 20:56:16 Maybe remove these console logs, or replace them w Maybe remove these console logs, or replace them with something testable (like setting a variable). chaitali 2014/03/04 19:33:45 These are strictly for debugging if the test fails Show quoted text On 2014/03/03 20:56:16, Jamie wrote: > Maybe remove these console logs, or replace them with something testable (like > setting a variable). These are strictly for debugging if the test fails. The variable setting happens on the client page for the test to read. I can remove them if you feel strongly about it but I think they will be useful for debugging when the test fails.
	26 });

	27 request.fail(function(jqXHR, textStatus) {

	28 console.log("Request failed: " + textStatus);

	29 });

	30 }

	31 });

	32 </script>

	33 </body>

	34 </html>

OLD	NEW