chrome/test/remoting/http_server/clientpage.html - Issue 180273015: Simple HTTP server for Chromoting End-to-End tests

Side by Side Diff: chrome/test/remoting/http_server/clientpage.html

Issue 180273015: Simple HTTP server for Chromoting End-to-End tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <title>Client Page</title>

	4 <link rel="stylesheet" href="//yui.yahooapis.com/pure/0.4.2/pure-min.css">
	Jamie 2014/03/03 20:56:16 Is this CSS essential for the test? If not, I woul Is this CSS essential for the test? If not, I would prefer not to depend on anything external. chaitali 2014/03/04 19:33:45 Done. Show quoted text On 2014/03/03 20:56:16, Jamie wrote: > Is this CSS essential for the test? If not, I would prefer not to depend on > anything external. Done.
	5 <script src="//ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></sc ript>

	6 </head>

	7 <body>

	8 <script>
	Jamie 2014/03/03 20:56:16 Please pull this script out into a separate .js fi Please pull this script out into a separate .js file and pull it in in the <head>. It makes for easier editing (and syntax highlighting in code-reviews), and we have tools to type-check JS source files, which have proven very useful in catching bugs. chaitali 2014/03/04 19:33:45 Done. Show quoted text On 2014/03/03 20:56:16, Jamie wrote: > Please pull this script out into a separate .js file and pull it in in the > <head>. It makes for easier editing (and syntax highlighting in code-reviews), > and we have tools to type-check JS source files, which have proven very useful > in catching bugs. Done.
	9 // Set some global variables

	10 var keypressSucceeded = false;

	11 var keypressText = "";
	anandc 2014/03/03 21:10:03 Single-braces for strings. http://dev.chromium.org Single-braces for strings. http://dev.chromium.org/developers/web-development-style-guide chaitali 2014/03/04 19:33:45 Done. Show quoted text On 2014/03/03 21:10:03, anandc wrote: > Single-braces for strings. > http://dev.chromium.org/developers/web-development-style-guide Done.
	12

	13 (function poll(){
	anandc 2014/03/03 21:10:03 pollForKeyPress() Also, space before opening-brace pollForKeyPress() Also, space before opening-brace. http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone... chaitali 2014/03/04 19:33:45 Added a TODO for myself. I would like it to poll f Added a TODO for myself. I would like it to poll for all test vars in each poll and keep polling till all are true. On 2014/03/03 21:10:03, anandc wrote: Show quoted text > pollForKeyPress() > Also, space before opening-brace. > http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...
	14 $.ajax({

	15 url: "/poll?test=keytest",

	16 type: "GET",

	17 success: function(data){

	18 console.log(data);

	19

	20 // If keypress succeeded then

	21 // update relevant vars and stop polling.

	22 if (data.keypressSucceeded == true) {

	23 keypressSucceeded = data.keypressSucceeded;

	24 keypressText = data.keypressText;

	25 } else {

	26 // If keypress did not succeed we should

	27 // continue polling.

	28 setTimeout(poll, 3000);

	29 }

	30 },

	31 dataType: "json"});

	32 })();
	Jamie 2014/03/03 20:56:16 I don't think there's much value in using this dec I don't think there's much value in using this declare-and-call syntax, given that the function is not anonymous. It's less readable than just explicitly calling poll() after declaring the function. chaitali 2014/03/04 19:33:45 Done. Show quoted text On 2014/03/03 20:56:16, Jamie wrote: > I don't think there's much value in using this declare-and-call syntax, given > that the function is not anonymous. It's less readable than just explicitly > calling poll() after declaring the function. Done.
	33 </script>

	34 </body>

	35 </html>

OLD	NEW

« no previous file with comments | « no previous file | chrome/test/remoting/http_server/hostpage.html » ('j') | chrome/test/remoting/http_server/hostpage.html » ('J')