Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1427)

Unified Diff: pkg/smoke/test/static_test.dart

Issue 180273004: Fixes in smoke, which in turn should fix todomvc. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/smoke/test/common.dart ('k') | samples/samples.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/smoke/test/static_test.dart
diff --git a/pkg/smoke/test/static_test.dart b/pkg/smoke/test/static_test.dart
index b410130fbdb230adc38958c16169d31c1497d68e..9ede1382ddc6b8b475f450a3f224da455b317c58 100644
--- a/pkg/smoke/test/static_test.dart
+++ b/pkg/smoke/test/static_test.dart
@@ -29,7 +29,14 @@ var _config = new StaticConfiguration(
#i: (o, v) { o.i = v; },
#j2: (o, v) { o.j2 = v; },
},
- parents: const {
+ // TODO(sigmund): this could be a const map, but that triggers
+ // dartbug.com/17123
+ // TODO(sigmund): before doing codegen for this, consider changing smoke's
+ // defaults so we don't need to specify obvious things like `int`, or `*:
+ // Object`.
+ parents: {
+ Annot: Object,
+ AnnotB: Annot,
A: Object,
B: Object,
C: Object,
@@ -41,6 +48,7 @@ var _config = new StaticConfiguration(
F2: F,
G: Object,
H: G,
+ int: Object,
},
declarations: {
B: {
@@ -94,6 +102,7 @@ var _config = new StaticConfiguration(
#f: const Declaration(#f, int, annotations: const [a1]),
#g: const Declaration(#g, int, annotations: const [a1]),
#h: const Declaration(#h, int, annotations: const [a2]),
+ #i: const Declaration(#i, int, annotations: const [a3]),
},
},
names: {#i: 'i'});
« no previous file with comments | « pkg/smoke/test/common.dart ('k') | samples/samples.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698