Fixes in smoke, which in turn should fix todomvc.

pkg/smoke/lib/mirrors.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Implementation of the smoke services using mirrors.
 library smoke.mirrors;
 
 import 'dart:mirrors';
 import 'package:smoke/smoke.dart';
 import 'package:logging/logging.dart';
@@ skipping 49 matching lines @@
         }
       }
       args = adjustList(args, required, required + optional);
     }
     return receiverMirror.invoke(methodName, args, namedArgs).reflectee;
   }
 }
 
 /// Implements [TypeInspectorService] using mirrors.
 class ReflectiveTypeInspectorService implements TypeInspectorService {
+  bool isSubclassOf(Type type, Type supertype) {
+    if (type == supertype || supertype == Object) return true;
+    // TODO(sigmund): change to mirror.isSubclassOf when it gets implemented in
+    // dart2js. (dartbug.com/12439)
+    var mirror = reflectClass(type);
+    var top = reflectClass(supertype);
+    while (mirror != _objectType) {
+      mirror = _safeSuperclass(mirror);
+      if (mirror == top) return true;
+    }
+    return false;
+  }
+
   bool hasGetter(Type type, Symbol name) {
     var mirror = reflectType(type);
     if (mirror is! ClassMirror) return false;
     while (mirror != _objectType) {
       final members = mirror.declarations;
       if (members.containsKey(name)) return true;
       mirror = _safeSuperclass(mirror);
     }
     return false;
   }
@@ skipping 50 matching lines @@
     return new _MirrorDeclaration(mirror, declaration);
   }
 
   List<Declaration> query(Type type, QueryOptions options) {
     var mirror = reflectType(type);
     if (mirror is! ClassMirror) return null;
     return _query(mirror, options);
   }
 
   List<Declaration> _query(ClassMirror cls, QueryOptions options) {
-    var result = (!options.includeInherited || cls.superclass == _objectType)
-        ? [] : _query(cls.superclass, options);
+    final visitParent = options.includeInherited && cls.superclass != null && 
+        cls.superclass != reflectClass(options.includeUpTo);

[Siggi Cherem (dart-lang), 2014/02/25 23:23:23]

note that for the same reasons than below (classes with type-args fail), we
don't do this instead:
  _toType(cls.superclass) != options.includeUpTo

[Jennifer Messerly, 2014/02/25 23:50:09]

might be worth adding this comment (it can refer to the one below), so we know
to clean it up when 16925 is fixed :)

[Siggi Cherem (dart-lang), 2014/02/26 00:09:50]

Done.

+    var result = visitParent ? _query(cls.superclass, options) : [];
     for (var member in cls.declarations.values) {
       if (member is! VariableMirror && member is! MethodMirror) continue;
       if (member.isStatic || member.isPrivate) continue;
       var name = member.simpleName;
       bool isMethod = false;
       if (member is VariableMirror) {
         if (!options.includeFields) continue;
         if (options.excludeFinal && member.isFinal) continue;
       }
 
@@ skipping 155 matching lines @@
   //     dartbug.com/16078).
   //   * having [call] also allows `is` checks to work for functions of 0
   //     through 3 arguments.  We depend on this in
   //     `polymer_expressions/lib/eval.dart` to check whether a function is a
   //     filter (takes a single argument). (Note that it's possible to include
   //     both [call] and [noSuchMethod], which would make instance-of checks
   //     work with the signature of [call], but will allow invoking the function
   //     using [noSuchMethod].
   call([a, b, c]) => invoke(receiver, methodName, [a, b, c], adjust: true);
 }