Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1802713002: Capture more details about failure to load ICU data file (Closed)

Created:
4 years, 9 months ago by scottmg
Modified:
4 years, 9 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Capture more details about failure to load ICU data file The last round of debug stuff showed that InitializeICUWithFileDescriptorInternal() is being called with an invalid handle. This means that the File() ctor is failing. It's almost definitely going to be something like access denied caused by AV, etc., but confirm that hypothesis by saving off the error on the file open. R=jshin@chromium.org BUG=445616 Committed: https://crrev.com/e608fde9371bff1d50ce7f79b5e479bfd921ff0e Cr-Commit-Position: refs/heads/master@{#381261}

Patch Set 1 #

Patch Set 2 : non win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M base/i18n/icu_util.cc View 1 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
4 years, 9 months ago (2016-03-14 20:06:03 UTC) #1
jungshik at Google
LGTM Thanks for digging into this.
4 years, 9 months ago (2016-03-15 18:15:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802713002/20001
4 years, 9 months ago (2016-03-15 18:30:05 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-15 18:35:59 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 18:36:54 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e608fde9371bff1d50ce7f79b5e479bfd921ff0e
Cr-Commit-Position: refs/heads/master@{#381261}

Powered by Google App Engine
This is Rietveld 408576698