Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1802643002: Adjust locationbar text vertical position under Material Design. (Closed)

Created:
4 years, 9 months ago by shrike
Modified:
4 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust locationbar text vertical position under Material Design. Under Material Design The location bar's text is currently positioned 1pt too low on non-Retina and 0.5pt too low on Retina. BUG=593727 Committed: https://crrev.com/4c4dbdf32ba3c71b928eb5169029571cd1713fa3 Cr-Commit-Position: refs/heads/master@{#381472}

Patch Set 1 #

Patch Set 2 : Code cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -14 lines) Patch
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm View 1 3 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm View 1 5 chunks +25 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
shrike
PTAL
4 years, 9 months ago (2016-03-16 00:26:02 UTC) #3
Avi (use Gerrit)
👍
4 years, 9 months ago (2016-03-16 01:28:58 UTC) #4
Avi (use Gerrit)
lgtm
4 years, 9 months ago (2016-03-16 01:29:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802643002/20001
4 years, 9 months ago (2016-03-16 16:13:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 16:48:37 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 16:49:47 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c4dbdf32ba3c71b928eb5169029571cd1713fa3
Cr-Commit-Position: refs/heads/master@{#381472}

Powered by Google App Engine
This is Rietveld 408576698