Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1802553004: Fix offset outside bounds warning on GCC (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Typo in comment. #

Patch Set 3 : Stray change removed. #

Total comments: 1

Patch Set 4 : Another typo in comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcrt/fx_string.h View 1 2 3 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Dan, for review.
4 years, 9 months ago (2016-03-14 17:27:05 UTC) #2
dsinclair
lgtm w/ nit. https://codereview.chromium.org/1802553004/diff/40001/core/include/fxcrt/fx_string.h File core/include/fxcrt/fx_string.h (right): https://codereview.chromium.org/1802553004/diff/40001/core/include/fxcrt/fx_string.h#newcode184 core/include/fxcrt/fx_string.h:184: // Implicit conversiont to uint8_t* -- ...
4 years, 9 months ago (2016-03-14 17:29:44 UTC) #3
Tom Sepez
4 years, 9 months ago (2016-03-14 17:48:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
54b0abed08048008498471e39b7c72b034474090 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698