Baselines for skia:2146

Baselines for skia:2146

BUG=skia:2146
Committed: http://code.google.com/p/skia/source/detail?r=13645

[borenet, 2014-02-25 21:30:26]

What are the risks of doing this?  Eg. if any of these are flaky we'll need to
remove the baseline or ignore-failure?

[epoger, 2014-02-25 21:39:11]

lgtm

https://codereview.chromium.org/180253004/diff/1/expectations/gm/Test-Android...
File
expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json
(right):

https://codereview.chromium.org/180253004/diff/1/expectations/gm/Test-Android...
expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json:1:
{
On 2014/02/25 21:30:26, borenet wrote:
> What are the risks of doing this?  Eg. if any of these are flaky we'll need to
> remove the baseline or ignore-failure?

Yes, if any of these prove to be flaky we will have to deal with it in one of
the following ways, from best to worst:

1. Mark the test as ignore-failure and associate it with a bug that tracks the
flakiness
2. Remove the expectation for the failing test
3. Add the test to ignored-expectations.txt

The only other "risk" I can think of is that these results may or may not really
be correct (you haven't examined them all)... but that's covered by the
reviewed-by-human field.

https://codereview.chromium.org/180253004/diff/1/expectations/gm/Test-Android...
expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json:1054:
"bugs": [
Skimming these, all the ones I've looked at have bug=2146 and
reviewed-by-human=false, as desired.

[bsalomon, 2014-02-25 21:41:29]

On 2014/02/25 21:30:26, borenet wrote:
> What are the risks of doing this?  Eg. if any of these are flaky we'll need to
> remove the baseline or ignore-failure?

Is this basically baseline all them without looking at them?

I think it is likely there are some flakes on the N4 and we'll have to
rediscover them. I'm not sure what other option there is, though. Even if tests
were marked ignore-failure on the N4 prior to the persp-bot-switch we probably
don't know if it was the N4 alone or the combination of the N4 plus persp that
made them flaky.

So, lgtm. Maybe pre-file a bug with a link from the dashboard saying we're
likely to detect flakes and mark ignore using that bug #.

[borenet, 2014-03-03 18:56:41]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-03-03 18:56:49]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/borenet@google.com/180253004/1

[commit-bot: I haz the power, 2014-03-03 18:56:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-03 18:56:56]

Failed to apply patch for
expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json
  Hunk #1 FAILED at 1.
  1 out of 1 hunk FAILED -- saving rejects to file
expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json.rej

Patch:      
expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json
Index:
expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json
diff --git
a/expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json
b/expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json
index
c45158fc60e9393b66111ef02750873289bd30ed..1508b3da182330e698976641c8a4579ff1d04204
100644
---
a/expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json
+++
b/expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json
@@ -1,287 +1,13103 @@
 {
   "expected-results": {
+    "3x3bitmaprect_565.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          9785004568147979273
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "3x3bitmaprect_8888.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          2628667696367439425
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "3x3bitmaprect_gpu.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          12538273179242692467
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "3x3bitmaprect_pdf-poppler.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          13297354158543590622
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "aaclip_565.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          14587121945766108415
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "aaclip_8888.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          879938603850352338
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "aaclip_gpu.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          14289234709997124031
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "aaclip_pdf-poppler.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          13583152795036681501
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "aarectmodes_565.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          11661377674282681505
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "aarectmodes_8888.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          11962100410894752644
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "aarectmodes_gpu.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          6558327361272317062
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "aarectmodes_pdf-poppler.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          9142208278131189334
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "alphagradients_565.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          11718955990685861152
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "alphagradients_8888.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          513371975634935769
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "alphagradients_gpu.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          5211736096109413510
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "alphagradients_pdf-poppler.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          4911699481875407549
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "arcofzorro_565.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          4349453473608603258
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "arcofzorro_8888.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          10637508332659652924
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "arcofzorro_gpu.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          17302422019077708424
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "arcofzorro_pdf-poppler.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          5025721531847734039
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "arithmode_565.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          6659255492155284077
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "arithmode_8888.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          3929863560806720936
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "arithmode_gpu.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          12135992436573664639
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "arithmode_pdf-poppler.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          9039820690343111490
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "bezier_conic_effects_gpu.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          11554818717104957989
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "bezier_cubic_effects_gpu.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          13409946290257088255
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "bezier_quad_effects_gpu.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          15469523540269981841
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "bicubicfilter_565.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          11517254730798722709
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "bicubicfilter_8888.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          3863076556093837165
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "bicubicfilter_gpu.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          8154155218608892427
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "bicubicfilter_pdf-poppler.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          13916889568279826355
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "bigbitmaprect_i_565.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          16851811445076645154
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "bigbitmaprect_i_8888.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          3651647081450355657
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "bigbitmaprect_i_gpu.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          6251931593610194237
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "bigbitmaprect_i_pdf-poppler.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          13821673598026340584
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "bigbitmaprect_s_565.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          16851811445076645154
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "reviewed-by-human": false
+    }, 
+    "bigbitmaprect_s_8888.png": {
+      "allowed-digests": [
+        [
+          "bitmap-64bitMD5", 
+          3651647081450355657
+        ]
+      ], 
+      "bugs": [
+        2146
+      ], 
+      "revi…
(message too large)

[borenet, 2014-03-03 19:05:52]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-03-03 19:06:09]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/borenet@google.com/180253004/60001

[commit-bot: I haz the power, 2014-03-03 19:31:11]

Change committed as 13645