Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 180243025: Changing the UsersPerSession UMA metric to only count possible multi profile sessions and do this u… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/browser/lifetime/application_lifetime.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 1cfa48fbc4b33e07a84cddffee94218413878b39..8144534c865d14ce4a27f9ed834fe32ee0be8995 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -8073,7 +8073,7 @@ other types of suffix sets.
counts are the number of discards and the buckets are the number of users.
Since the count values are absolute numbers, they need to be normalized
before use - so divide the counts by the percentage of users found under
- 'MultiProfile.UsersPerSession'.
+ 'MultiProfile.UsersPerSessionIncremental'.
Mark P 2014/03/06 21:36:33 The math still doesn't work. Take my earlier exam
Mr4D (OOO till 08-26) 2014/03/06 23:01:25 Right. That is a possibility (but it unfortunately
</summary>
</histogram>
@@ -8118,12 +8118,25 @@ other types of suffix sets.
</histogram>
<histogram name="MultiProfile.UsersPerSession">
+ <obsolete>
+ Deprecated 3/2014, renamed.
James Cook 2014/03/06 20:23:14 Often we list the name of the stat it got renamed
Mr4D (OOO till 08-26) 2014/03/06 23:01:25 Done. (when adding this I glanced over the <obsole
+ </obsolete>
<summary>
The number of users simultaneously signed into a multiprofile session on
Chrome OS. This is recorded whenever a new user logs in.
Mark P 2014/03/06 21:36:33 If this was actually recorded on shutdown, please
Mr4D (OOO till 08-26) 2014/03/06 23:01:25 Done.
</summary>
</histogram>
+<histogram name="MultiProfile.UsersPerSessionIncremental">
+ <summary>
+ The number of users simultaneously signed into a multiprofile session on
+ Chrome OS. This is recorded whenever a user gets added to the session. To
+ get the correct count, all following counts must be subtracted. Example: If
+ 100 single user, 20 two user and 5 three user sessions, there were
+ 100-20-5=75 single user sessions, 100-80=20 dual user sessions and so on.
+ </summary>
+</histogram>
+
<histogram name="NaCl.Client.Helper.InitState" enum="NaClHelperStatus">
<summary>
When the browser started, what happened with the NaCl helper process?
« no previous file with comments | « chrome/browser/lifetime/application_lifetime.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698