pkg/docgen/lib/src/models.dart - Issue 180243024: pkg/docgen: refactoring and cleanup

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/docgen/lib/src/models.dart

Issue 180243024: pkg/docgen: refactoring and cleanup (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: just refactoring Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 library docgen.moedls;
	Alan Knight 2014/03/12 18:17:56 typo typo kevmoo 2014/03/17 02:01:29 Done. Show quoted text On 2014/03/12 18:17:56, Alan Knight wrote: > typo Done.
	2

	3 import '../../../../sdk/lib/_internal/compiler/implementation/mirrors/source_mir rors.dart';

	4 import '../../../../sdk/lib/_internal/compiler/implementation/mirrors/mirrors_ut il.dart'

	5 as dart2js_util;

	6

	7 /// Docgen representation of an item to be documented, that wraps around a

	8 /// dart2js mirror.

	9 abstract class MirrorBased {

	10 /// The original dart2js mirror around which this object wraps.

	11 DeclarationMirror get mirror;

	12 }

	13

	14 /// A Docgen wrapper around the dart2js mirror for a generic type.

	15 class Generic extends MirrorBased {

	16 final TypeVariableMirror mirror;

	17

	18 Generic(this.mirror);

	19

	20 Map toMap() => {

	21 'name': dart2js_util.nameOf(mirror),

	22 'type': dart2js_util.qualifiedNameOf(mirror.upperBound)

	23 };

	24 }
	Emily Fortuna 2014/03/06 22:05:38 what about putting Type and Parameter here, too? T what about putting Type and Parameter here, too? Those also only extend MirrorBased. kevmoo 2014/03/06 22:20:17 I wish, but there is a lot of dependency spaghetti Show quoted text On 2014/03/06 22:05:38, Emily Fortuna wrote: > what about putting Type and Parameter here, too? Those also only extend > MirrorBased. I wish, but there is a lot of dependency spaghetti. This is a first stab.
OLD	NEW