Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 180243023: Simplify BatteryManager class and cleanups. (Closed)

Created:
6 years, 9 months ago by Srini
Modified:
6 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Simplify BatteryManager class and cleanups. R=Chris Dumez, abarth BUG=122593 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168665

Patch Set 1 #

Total comments: 1

Patch Set 2 : Override interfaceName() in BatteryManager. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16 lines) Patch
M Source/modules/battery/BatteryManager.h View 1 2 chunks +4 lines, -15 lines 0 comments Download
M Source/modules/battery/NavigatorBattery.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Srini
Hi Chris, Can you review this patch? It fixes the comments you had mentioned on ...
6 years, 9 months ago (2014-03-06 14:03:58 UTC) #1
Inactive
On 2014/03/06 14:03:58, Srini wrote: > Hi Chris, > > Can you review this patch? ...
6 years, 9 months ago (2014-03-06 14:10:14 UTC) #2
Srini
Hi Abarth/Chris, Can you review this patch? Thanks, -Srini.
6 years, 9 months ago (2014-03-06 14:14:25 UTC) #3
Srini
On 2014/03/06 14:10:14, Chris Dumez wrote: > On 2014/03/06 14:03:58, Srini wrote: > > Hi ...
6 years, 9 months ago (2014-03-06 14:15:25 UTC) #4
Inactive
Hey Srini, long time no see :) Nice to see you are contributing to Blink ...
6 years, 9 months ago (2014-03-06 15:35:26 UTC) #5
Inactive
https://codereview.chromium.org/180243023/diff/1/Source/modules/battery/BatteryManager.h File Source/modules/battery/BatteryManager.h (right): https://codereview.chromium.org/180243023/diff/1/Source/modules/battery/BatteryManager.h#newcode24 Source/modules/battery/BatteryManager.h:24: virtual const WTF::AtomicString& interfaceName() const { return EventTargetNames::BatteryManager; } ...
6 years, 9 months ago (2014-03-06 15:35:41 UTC) #6
Srini
On 2014/03/06 15:35:41, Chris Dumez wrote: > https://codereview.chromium.org/180243023/diff/1/Source/modules/battery/BatteryManager.h > File Source/modules/battery/BatteryManager.h (right): > > https://codereview.chromium.org/180243023/diff/1/Source/modules/battery/BatteryManager.h#newcode24 ...
6 years, 9 months ago (2014-03-06 18:40:45 UTC) #7
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-06 18:46:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srinivasa.ragavan.venkateswaran@intel.com/180243023/20001
6 years, 9 months ago (2014-03-06 18:47:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srinivasa.ragavan.venkateswaran@intel.com/180243023/20001
6 years, 9 months ago (2014-03-06 19:03:10 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 19:32:51 UTC) #11
Message was sent while issue was closed.
Change committed as 168665

Powered by Google App Engine
This is Rietveld 408576698