Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Unified Diff: Source/core/svg/properties/SVGAnimatedProperty.cpp

Issue 180243018: Remove SVGAnimatedProperty::animatedPropertyCache (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/properties/SVGAnimatedProperty.cpp
diff --git a/Source/core/svg/properties/SVGAnimatedProperty.cpp b/Source/core/svg/properties/SVGAnimatedProperty.cpp
index b1e1e7835cdc6d546d5216195cdead1d12f713fc..1f81a1cf8b9b069109c1701fb6965a05b3170f83 100644
--- a/Source/core/svg/properties/SVGAnimatedProperty.cpp
+++ b/Source/core/svg/properties/SVGAnimatedProperty.cpp
@@ -41,30 +41,6 @@ SVGAnimatedProperty::~SVGAnimatedProperty()
ASSERT(!m_isAnimating);
}
-void SVGAnimatedProperty::detachAnimatedPropertiesForElement(SVGElement* element)
-{
- // Remove wrappers from cache.
- Cache* cache = animatedPropertyCache();
-
- Vector<SVGAnimatedPropertyDescription> keysToRemove;
-
- const Cache::const_iterator end = cache->end();
- for (Cache::const_iterator it = cache->begin(); it != end; ++it) {
- if (it->key.m_element == element) {
- it->value->resetContextElement();
- keysToRemove.append(it->key);
- }
- }
-
- for (Vector<SVGAnimatedPropertyDescription>::const_iterator it = keysToRemove.begin(); it != keysToRemove.end(); ++it) {
- // http://crbug.com/333156 :
- // There are cases where detachAnimatedPropertiesForElement is called recursively from ~SVGAnimatedProperty.
- // This below protect makes this function safe by deferring the recursive call until we finish touching the HashMap.
- RefPtr<SVGAnimatedProperty> protect = cache->get(*it);
- cache->remove(*it);
- }
-}
-
void SVGAnimatedProperty::commitChange()
{
ASSERT(m_contextElement);
@@ -73,10 +49,4 @@ void SVGAnimatedProperty::commitChange()
m_contextElement->svgAttributeChanged(m_attributeName);
}
-SVGAnimatedProperty::Cache* SVGAnimatedProperty::animatedPropertyCache()
-{
- static Cache* s_cache = new Cache;
- return s_cache;
-}
-
} // namespace WebCore
« no previous file with comments | « Source/core/svg/properties/SVGAnimatedProperty.h ('k') | Source/core/svg/properties/SVGAnimatedPropertyMacros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698