Issue 180243010: Delete the simulator when we don't need it anymore

Issue 180243010: Delete the simulator when we don't need it anymore (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 9 months ago

Reviewers:
Sven Panne, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Delete the simulator when we don't need it anymore BUG=none R=svenpanne@chromium.org, ulan@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=19598

Patch Set 2 : updates #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
M	src/arm/simulator-arm.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/isolate.h	View	1	2 chunks	+1 line, -14 lines	0 comments	Download
M	src/isolate.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/mips/simulator-mips.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

https://codereview.chromium.org/180243010/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/180243010/diff/1/src/isolate.cc#newcode1467 src/isolate.cc:1467: #if defined(USE_SIMULATOR) Can't we simply remove this #if and ...

6 years, 9 months ago (2014-02-27 10:42:52 UTC) #2

jochen (gone - plz use gerrit)

6 years, 9 months ago (2014-02-27 14:43:12 UTC) #3

jochen (gone - plz use gerrit)

6 years, 9 months ago (2014-02-28 10:55:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r19598 (tree was closed).

Expand Messages | Collapse Messages