Make gclient_scm.py use cache_dir

tests/gclient_utils_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import StringIO
 import sys
 
 sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
 from testing_support.super_mox import SuperMoxTestBase
 from testing_support import trial_dir
 
 import gclient_utils
 import subprocess2
 
 
 class GclientUtilBase(SuperMoxTestBase):
   def setUp(self):
     super(GclientUtilBase, self).setUp()
     gclient_utils.sys.stdout.flush = lambda: None
     self.mox.StubOutWithMock(subprocess2, 'Popen')
     self.mox.StubOutWithMock(subprocess2, 'communicate')
 
 
-class GclientUtilsUnittest(GclientUtilBase):

[agable, 2014/02/28 02:06:32]

You could fix the expectation in the test instead of removing the test entirely.

But honestly it's a horrible test so I'm okay with this.

[Ryan Tseng, 2014/02/28 02:22:50]

I got a verbal OK from Robbie already :)

-  """General gclient_utils.py tests."""
-  def testMembersChanged(self):
-    members = [
-        'Annotated', 'AutoFlush', 'CheckCallAndFilter', 'CommandToStr',
-        'CheckCallAndFilterAndHeader', 'Error', 'ExecutionQueue', 'FileRead',
-        'FileWrite', 'FindFileUpwards', 'FindGclientRoot',
-        'GetGClientRootAndEntries', 'GetEditor', 'GetExeSuffix',
-        'GetMacWinOrLinux', 'GitFilter', 'IsDateRevision', 'MakeDateRevision',
-        'MakeFileAutoFlush', 'MakeFileAnnotated', 'PathDifference',
-        'ParseCodereviewSettingsContent', 'NumLocalCpus', 'PrintableObject',
-        'RETRY_INITIAL_SLEEP', 'RETRY_MAX', 'RunEditor', 'GCLIENT_CHILDREN',
-        'GCLIENT_CHILDREN_LOCK', 'GClientChildren', 'SplitUrlRevision',
-        'SyntaxErrorToError', 'UpgradeToHttps', 'Wrapper', 'WorkItem',
-        'codecs', 'lockedmethod', 'logging', 'os', 'pipes', 'Queue', 're',
-        'rmtree', 'safe_makedirs', 'safe_rename', 'stat', 'subprocess',
-        'subprocess2', 'sys', 'tempfile', 'threading', 'time', 'urlparse',
-
-    ]
-    # If this test fails, you should add the relevant test.
-    self.compareMembers(gclient_utils, members)
-
-
-
 class CheckCallAndFilterTestCase(GclientUtilBase):
   class ProcessIdMock(object):
     def __init__(self, test_string):
       self.stdout = StringIO.StringIO(test_string)
       self.pid = 9284
     # pylint: disable=R0201
     def wait(self):
       return 0
 
   def _inner(self, args, test_string):
@@ skipping 155 matching lines @@
     for content, expected in values:
       self.assertEquals(
           expected, gclient_utils.ParseCodereviewSettingsContent(content))
 
 
 if __name__ == '__main__':
   import unittest
   unittest.main()
 
 # vim: ts=2:sw=2:tw=80:et: