Bugfix in DOM bindings: canonicalize URLs even if no ApplicationLoader is available

DartApplicationLoader.h

Index: DartApplicationLoader.h
diff --git a/DartApplicationLoader.h b/DartApplicationLoader.h
index cd6fedd71969759915e8c8d04fc30d08f82db211..9b0d8116ff4fda98812dfd4a2f5caafda3fcbc4c 100644
--- a/DartApplicationLoader.h
+++ b/DartApplicationLoader.h
@@ -67,8 +67,9 @@ private:
     void scriptLoadError(String failedUrl);
     void loadMainScript(const String& url, const String& source);
 
-    static Dart_Handle libraryTagHandlerCallback(Dart_LibraryTag tag, Dart_Handle library, Dart_Handle url);
-    Dart_Handle libraryTagHandler(Dart_LibraryTag tag, Dart_Handle library, Dart_Handle url);
+    static Dart_Handle libraryTagHandlerCallback(Dart_LibraryTag, Dart_Handle library, Dart_Handle urlHandle);

[siva, 2013/07/12 01:05:44]

Dart_LibraryTag tag,

[kustermann, 2013/07/12 16:02:21]

I didn't want to remove it, but I had a hard time arguing with the webkit style
checker:

$ ./Tools/Scripts/check-webkit-style 
Source/bindings/dart/DartApplicationLoader.h:70:  The parameter name "tag" adds
no information, so it should be removed.  [readability/parameter_name] [5]
Source/bindings/dart/DartApplicationLoader.h:72:  The parameter name "tag" adds
no information, so it should be removed.  [readability/parameter_name] [5]

I think it outputs this warning if the name of the parameter is a substring of
the typename -- or something similar.

To keep the files free of style warnings, I'll let it as it is now.

[siva, 2013/07/12 16:58:09]

That is a very weird style guideline. Thanks for the explanation..

On 2013/07/12 16:02:21, kustermann wrote:

+    static Dart_Handle CanonicalizeUrl(Dart_Handle library, Dart_Handle urlHandle, String url);
+    Dart_Handle libraryTagHandler(Dart_LibraryTag, Dart_Handle library, Dart_Handle urlHandle, String url);

[siva, 2013/07/12 01:05:44]

Dart_LibraryTag tag,

 
     Dart_Isolate m_isolate;
     // Client must ensure that DartApplicationLoader doesn't outlive corresponding document.