[wasm] Add --trace-wasm-ast-start and --trace-wasm-ast-end options and improve tracing.

[wasm] Add --trace-wasm-ast-start and --trace-wasm-ast-end options and improve tracing.

R=ahaas@chromium.org,mtrofin@chromium.org
BUG=

Committed: https://crrev.com/e38efdefd3788b54832fb8d167536b0a05baf43a
Cr-Commit-Position: refs/heads/master@{#34843}

[ahaas, 2016-03-15 14:24:55]

lgtm

https://codereview.chromium.org/1802353002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/1802353002/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:471: DEFINE_INT(trace_wasm_ast_end, 0, "end function for
WASM AST trace")
You could add "(exclusive)" to state that this is an exclusive bound.

https://codereview.chromium.org/1802353002/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/1802353002/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:1704: printf("// locals:");
Why do you mix streams and printf here?

[titzer, 2016-03-15 17:18:04]

https://codereview.chromium.org/1802353002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/1802353002/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:471: DEFINE_INT(trace_wasm_ast_end, 0, "end function for
WASM AST trace")
On 2016/03/15 14:24:55, ahaas wrote:
> You could add "(exclusive)" to state that this is an exclusive bound.

Done.

https://codereview.chromium.org/1802353002/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/1802353002/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:1704: printf("// locals:");
On 2016/03/15 14:24:55, ahaas wrote:
> Why do you mix streams and printf here?

Meh, it's a mix because of some 0x%02x things below.

[titzer, 2016-03-15 17:18:08]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-03-15 17:18:08]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/1802353002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-03-15 17:18:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1802353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1802353002/20001

[commit-bot: I haz the power, 2016-03-15 17:23:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-15 17:23:27]

Try jobs failed on following builders:
  v8_win_compile_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/1...)
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/4398)

[titzer, 2016-03-16 14:54:39]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-03-16 14:54:40]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/1802353002/#ps40001
(title: "Stupid signed/unsigned")

[commit-bot: I haz the power, 2016-03-16 14:54:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1802353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1802353002/40001

[commit-bot: I haz the power, 2016-03-16 14:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 14:57:56]

Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[titzer, 2016-03-16 15:02:12]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-03-16 15:02:12]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/1802353002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-03-16 15:02:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1802353002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1802353002/60001

[commit-bot: I haz the power, 2016-03-16 15:09:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 15:09:19]

Try jobs failed on following builders:
  v8_win64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/4577)
  v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compil...)

[titzer, 2016-03-17 08:19:43]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-03-17 08:19:43]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/1802353002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-03-17 08:19:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1802353002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1802353002/80001

[commit-bot: I haz the power, 2016-03-17 08:21:56]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-17 08:25:21]

Description was changed from

==========
[wasm] Add --trace-wasm-ast-start and --trace-wasm-ast-end options and improve
tracing.

R=ahaas@chromium.org,mtrofin@chromium.org
BUG=
==========

to

==========
[wasm] Add --trace-wasm-ast-start and --trace-wasm-ast-end options and improve
tracing.

R=ahaas@chromium.org,mtrofin@chromium.org
BUG=

Committed: https://crrev.com/e38efdefd3788b54832fb8d167536b0a05baf43a
Cr-Commit-Position: refs/heads/master@{#34843}
==========

[commit-bot: I haz the power, 2016-03-17 08:25:23]

Patchset 5 (id:??) landed as
https://crrev.com/e38efdefd3788b54832fb8d167536b0a05baf43a
Cr-Commit-Position: refs/heads/master@{#34843}