Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 1802343002: S390: Check in OWNER file on to s390 directory (Closed)

Created:
4 years, 9 months ago by john.yan
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : S390: Check in OWNER file on to s390 directory #

Patch Set 3 : S390: Check in OWNER file on to s390 directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-3 lines, --8 lines) Patch
A + src/compiler/s390/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/crankshaft/s390/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/debug/s390/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/full-codegen/s390/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/ic/s390/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/regexp/s390/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/s390/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/cctest/OWNERS View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A + test/unittests/compiler/s390/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
john.yan
S390: Check in OWNER file on to s390 directory
4 years, 9 months ago (2016-03-15 13:54:23 UTC) #1
Jakob Kummerow
LGTM with suggestions: - add test/unittests/compiler/s390/OWNERS while you're here - add per-file owners in test/cctest/OWNERS ...
4 years, 9 months ago (2016-03-15 13:58:58 UTC) #2
Yang
On 2016/03/15 13:58:58, Jakob wrote: > LGTM with suggestions: > - add test/unittests/compiler/s390/OWNERS while you're ...
4 years, 9 months ago (2016-03-15 13:59:46 UTC) #3
Michael Starzinger
LGTM.
4 years, 9 months ago (2016-03-15 14:01:20 UTC) #5
john.yan
On 2016/03/15 13:58:58, Jakob wrote: > LGTM with suggestions: > - add test/unittests/compiler/s390/OWNERS while you're ...
4 years, 9 months ago (2016-03-15 14:04:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802343002/40001
4 years, 9 months ago (2016-03-15 14:05:08 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-15 14:25:31 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 14:25:45 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6b503884aeb87ea307a513b277f28ffa0a2bb95e
Cr-Commit-Position: refs/heads/master@{#34789}

Powered by Google App Engine
This is Rietveld 408576698