|
|
Description[iOS] Remove dependencies on //ipc from //ui/events.
Remove problematic dependencies on //ipc from //ui/events when targetting
iOS (Chrome on iOS cannot depends on //ipc nor //content).
BUG=459705
Committed: https://crrev.com/da7ea5740b9019ba49f7bde22950875a421ad2a1
Cr-Commit-Position: refs/heads/master@{#381631}
Patch Set 1 #Patch Set 2 : Fix "gn check" on iOS #Patch Set 3 : Fix "gn check" on iOS #
Messages
Total messages: 29 (14 generated)
sdefresne@chromium.org changed reviewers: + sadrul@chromium.org
sdefresne@chromium.org changed reviewers: + avi@chromium.org - sadrul@chromium.org
-sadrul (OOO), +avi: Please take a look.
lgtm works for me.
Description was changed from ========== [iOS] Remove dependencies on //ipc from //ui/events. Remove problematic dependencies on //ipc from //ui/events when targetting iOS (Chrome on iOS cannot depends on //ipc not //content). BUG=459705 ========== to ========== [iOS] Remove dependencies on //ipc from //ui/events. Remove problematic dependencies on //ipc from //ui/events when targetting iOS (Chrome on iOS cannot depends on //ipc nor //content). BUG=459705 ==========
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802333002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org Link to the patchset: https://codereview.chromium.org/1802333002/#ps20001 (title: "Fix "gn check" on iOS")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802333002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
I had to make changes to ui/events/latency_info.h to get "gn check" to pass on iOS. Could you take another look? If you do not have additional comments could you send to CQ?
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802333002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm. Avi, feel like doing another stamp of this? I'll give you a couple of hours to respond and if you don't cq it myself ... it's easy enough to revert if there are issues.
The CQ bit was checked by dpranke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org Link to the patchset: https://codereview.chromium.org/1802333002/#ps40001 (title: "Fix "gn check" on iOS")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802333002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [iOS] Remove dependencies on //ipc from //ui/events. Remove problematic dependencies on //ipc from //ui/events when targetting iOS (Chrome on iOS cannot depends on //ipc nor //content). BUG=459705 ========== to ========== [iOS] Remove dependencies on //ipc from //ui/events. Remove problematic dependencies on //ipc from //ui/events when targetting iOS (Chrome on iOS cannot depends on //ipc nor //content). BUG=459705 Committed: https://crrev.com/da7ea5740b9019ba49f7bde22950875a421ad2a1 Cr-Commit-Position: refs/heads/master@{#381631} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/da7ea5740b9019ba49f7bde22950875a421ad2a1 Cr-Commit-Position: refs/heads/master@{#381631}
Message was sent while issue was closed.
lgtm stampity stampity stamp |