Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1802333002: [iOS] Remove dependencies on //ipc from //ui/events. (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@jpeg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Remove dependencies on //ipc from //ui/events. Remove problematic dependencies on //ipc from //ui/events when targetting iOS (Chrome on iOS cannot depends on //ipc nor //content). BUG=459705 Committed: https://crrev.com/da7ea5740b9019ba49f7bde22950875a421ad2a1 Cr-Commit-Position: refs/heads/master@{#381631}

Patch Set 1 #

Patch Set 2 : Fix "gn check" on iOS #

Patch Set 3 : Fix "gn check" on iOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M ui/events/BUILD.gn View 2 5 chunks +7 lines, -4 lines 0 comments Download
M ui/events/latency_info.h View 1 2 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 29 (14 generated)
sdefresne
4 years, 9 months ago (2016-03-15 13:36:23 UTC) #2
sdefresne
-sadrul (OOO), +avi: Please take a look.
4 years, 9 months ago (2016-03-15 14:22:20 UTC) #4
Avi (use Gerrit)
lgtm works for me.
4 years, 9 months ago (2016-03-15 15:52:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802333002/1
4 years, 9 months ago (2016-03-16 10:19:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/5045)
4 years, 9 months ago (2016-03-16 10:28:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802333002/20001
4 years, 9 months ago (2016-03-16 13:33:54 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/5085)
4 years, 9 months ago (2016-03-16 13:39:38 UTC) #15
sdefresne
I had to make changes to ui/events/latency_info.h to get "gn check" to pass on iOS. ...
4 years, 9 months ago (2016-03-16 13:55:43 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802333002/40001
4 years, 9 months ago (2016-03-16 13:58:38 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 15:07:30 UTC) #20
Dirk Pranke
lgtm. Avi, feel like doing another stamp of this? I'll give you a couple of ...
4 years, 9 months ago (2016-03-16 22:23:58 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802333002/40001
4 years, 9 months ago (2016-03-17 01:22:02 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-17 01:28:05 UTC) #26
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/da7ea5740b9019ba49f7bde22950875a421ad2a1 Cr-Commit-Position: refs/heads/master@{#381631}
4 years, 9 months ago (2016-03-17 01:30:02 UTC) #28
Avi (use Gerrit)
4 years, 9 months ago (2016-03-17 02:20:43 UTC) #29
Message was sent while issue was closed.
lgtm

stampity stampity stamp

Powered by Google App Engine
This is Rietveld 408576698