Issue 180233003: Revert r228205.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180233003: Revert r228205. (Closed)

Created:
6 years, 10 months ago by wtc

Modified:
6 years, 10 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/nss/

Visibility:
Public.

More Reviews

Description

Revert r228205. > Disable optimization in prdtoa.c under VS2013. > > Causes a compiler ICE. Upstream bug marked fixed, so this can be > removed on a subsequent compiler release. > > BUG=288948 R=scottmg@chromium.org BUG=none TEST=none

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -26 lines)			Patch
M	README.chromium	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	nspr/pr/src/misc/prdtoa.c	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	patches/nspr-disable-optimization-2013.patch	View	1 chunk	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/180233003/1

6 years, 10 months ago (2014-02-25 23:49:27 UTC) #4

Message was sent while issue was closed.

Change committed as 253292

Expand Messages | Collapse Messages